Re: [flashrom] [PATCH 1/8] ichspi.c: make REGWRITE* macros safer

[Carl-Daniel Hailfinger]

Am 28.06.2011 05:33 schrieb Stefan Tauner:
> '+' does have a quite high precedence so "calling" those macros with a term including weaker
> operators in the off parameter may have unexpected consequences
>
> Signed-off-by: Stefan Tauner

Good find!
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH 1/8] ichspi.c: make REGWRITE* macros safer

[Stefan Tauner]

On Fri, 01 Jul 2011 01:12:00 +0200
Carl-Daniel Hailfinger  wrote:
> Am 28.06.2011 05:33 schrieb Stefan Tauner:
> > '+' does have a quite high precedence so "calling" those macros with a term including weaker
> > operators in the off parameter may have unexpected consequences
> >
> > Signed-off-by: Stefan Tauner
>
> Good find!
> Acked-by: Carl-Daniel Hailfinger

thanks :) r1359