Using programmer_delay when serial is being used, could cause a major recursion (and breakage of the serial protocol). This has not been noticed because apparently all serial drivers used appear to always write >0 bytes, but still...
Signed-off-by: Urja Rannikko urjaman@gmail.com --- serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/serial.c b/serial.c index 4d912ba..126079a 100644 --- a/serial.c +++ b/serial.c @@ -357,7 +357,7 @@ int serialport_write(unsigned char *buf, unsigned int writecnt) if (!tmp) { msg_pdbg2("Empty write\n"); empty_writes--; - programmer_delay(500); + internal_delay(500); if (empty_writes == 0) { msg_perr("Serial port is unresponsive!\n"); return 1;
On Mon, 14 Oct 2013 14:24:30 +0000 Urja Rannikko urjaman@gmail.com wrote:
Using programmer_delay when serial is being used, could cause a major recursion (and breakage of the serial protocol). This has not been noticed because apparently all serial drivers used appear to always write >0 bytes, but still...
Signed-off-by: Urja Rannikko urjaman@gmail.com
Thanks, very good catch! Commit message refined, Acked-by: Stefan Tauner stefan.tauner@student.tuwien.ac.at and committed in r1759.