[PATCH] Pre-release polishing

[Uwe Hermann]

See patch.

Uwe.

[Carl-Daniel Hailfinger]

On 17.03.2010 18:36, Uwe Hermann wrote:
> Polish the flashrom code comments and outputs a bit.
> Fix a number of typos (found via ispell).
> Use correct vendor names (as per their websites) consistently.

Cool, thanks.
> Signed-off-by: Uwe Hermann
> Index: serprog.c
>
> --- serprog.c	(Revision 947)
> +++ serprog.c	(Arbeitskopie)
> @@ -66,7 +66,7 @@
>  /* Bitmap of supported commands */
>  static uint8_t sp_cmdmap[32];
>
> -/* sp_prev_was_write used to detect writes with continouous addresses
> +/* sp_prev_was_write used to detect writes with continuous addresses

Shouldn't that be "contiguous"?
> and combine them to write-n's */
> Index: board_enable.c
>
> --- board_enable.c	(Revision 947)
> +++ board_enable.c	(Arbeitskopie)

Can you please check these hunks for conflicts with existing unmerged
board enable patches? I'd rather keep the additional work for merging
them at a manageable level.
It is unclear whether nvidia has the official spelling NVIDIA or nVIDIA
or nVidia. It may have changed over time.

If you have answers for the serprog and board enable stuff (which may
require leaving out the board enable part for now), this is
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[Uwe Hermann]

On Wed, Mar 17, 2010 at 07:07:50PM +0100, Carl-Daniel Hailfinger wrote:
> > -/* sp_prev_was_write used to detect writes with continouous addresses
> > +/* sp_prev_was_write used to detect writes with continuous addresses
>
> Shouldn't that be "contiguous"?

Probably, yes. Fixed.
> > Index: board_enable.c
> >
> > --- board_enable.c	(Revision 947)
> > +++ board_enable.c	(Arbeitskopie)
>
> Can you please check these hunks for conflicts with existing unmerged
> board enable patches? I'd rather keep the additional work for merging
> them at a manageable level.

Should no longer be a problem, most stuff was merged.
> It is unclear whether nvidia has the official spelling NVIDIA or nVIDIA
> or nVidia. It may have changed over time.

True, but the current website seems to use NVIDIA quite consistently, so
I'd use that variant.
> Acked-by: Carl-Daniel Hailfinger

Thanks, r985.

Uwe.