[Flashrom] [PATCH] Convert flashchips to use struct eraseblock - Atmel

[Carl-Daniel Hailfinger]

On 22.12.2009 21:46, Sean Nelson wrote:
> Convert the following chips to use struct eraseblock:
> AT25DF021
> AT25DF041A
> AT25DF081
> AT25DF161
> AT25DF321
> AT25DF321A
> AT25DF641
> AT25F512B
> AT25FS010
> AT25FS040
> AT26DF041
> AT26DF081A
> AT26DF161
> AT26DF161A
> AT26F004
> AT29C512
> AT29C010A
> AT29C020
> AT29C040A
> AT49BV512
> AT49F002(N)
> AT49F002(N)T
>
> Signed-off-by: Sean Nelson

Sorry if my reviews seem to be obnoxious, but I noticed an oddness you
surely can explain:
Chips with the old erase function spi_chip_erase_60_c7 seem to be
missing the c7 variant after conversion. And I think some of the chips
supports both 52 and d8 for block erase with same sector size and only
one is listed.
We have to list all known erase function variants even if they have
identical eraseblock sizes because on Intel/VIA chipsets one (or more)
of the commands may be forbidden by the chipset configuration.

I'm impressed by the amount of datasheet reading you did in such short
time. Keep up the good work!

Regards,
Carl-Daniel

[Sean Nelson]

Fixed/Added C7h and D8h block erasers. More info in patch.

[Sean Nelson]

Updated patch with better/increased context for better reviewing and 
against latest svn.
Signoff in patch.

[Sean Nelson]

see patch.

[Carl-Daniel Hailfinger]

On 23.12.2009 04:30, Sean Nelson wrote:
> Convert the following chips to use struct eraseblock:
> AT25*
> AT26*
> AT29C*
> AT49BV512
> AT49F002(N)
> AT49F002(N)T
>
> Forth revision of patch includes:
> spi_block_erase_c7 for all SPI Atmel chips.
> spi_block_erase_d8 for some chip that support alternate commands for certain block sizes.
> Updated patch with better/increased context for better reviewing and against latest svn.
> Fixed correct block sizes for AT49F002.
> Fixed AT26F004's block counts for all block sizes.

Great, thanks.
> A possible future patch would to add spi_block_erase_d7 to spi.c as an 
> alternate to spi_block_erase_20. Only some SPI chips support d7.
>
> Signed-off-by: Sean Nelson

I fixed up compilation (missing comma at the end of line 1098) and
removed one extraneous whitespace at the end of a line.

Acked-by: Carl-Daniel Hailfinger 
and committed in r817.

Regards,
Carl-Daniel