[PATCH] Fixed decoding of SB600 LPC ROM protection registers

Fixed decoding of SB600 LPC ROM protection registers. The address part was using a bit of the size, the size was missing the upper bit, was off by 1023 bytes and included the protection bits. Signed-off-by: Mathias Krause <mathias.krause@secunet.com> Regards, Mathias

Hi Mathias, thanks for your patch. Minor nitpick: On 21.12.2010 16:17, Mathias Krause wrote:
(prot & 0xfffff800) + (((((prot & 0x7fc) >> 2) + 1) << 10) - 1));
This one looks a bit odd. How about (prot & 0xfffff800) + ((((prot & 0x7fc) >> 2) << 10) | 0x3ff); Looks good otherwise. Regards, Carl-Daniel -- http://www.hailfinger.org/

Hi Carl-Daniel, On 22.12.2010 02:33, Carl-Daniel Hailfinger wrote:
thanks for your patch.
Thanks for the review!
Minor nitpick:
On 21.12.2010 16:17, Mathias Krause wrote:
(prot & 0xfffff800) + (((((prot & 0x7fc) >> 2) + 1) << 10) - 1));
This one looks a bit odd. How about
(prot & 0xfffff800) + ((((prot & 0x7fc) >> 2) << 10) | 0x3ff);
My solution really looks odd but how about that one: (prot & 0xfffff800) + (((prot & 0x7fc) << 8) | 0x3ff)); New patch attached: Fixed decoding of SB600 LPC ROM protection registers. The address part was using a bit of the size, the size was missing the upper bit, was off by 1023 bytes and included the protection bits. Signed-off-by: Mathias Krause <mathias.krause at secunet.com> Regards, Mathias

Auf 22.12.2010 10:26, Mathias Krause schrieb:
Fix decoding of SB600 LPC ROM protection registers.
The address part was using a bit of the size, the size was missing the upper bit, was off by 1023 bytes and included the protection bits.
Signed-off-by: Mathias Krause <mathias.krause at secunet.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Do you have commit access? Regards, Carl-Daniel -- http://www.hailfinger.org/

On 23.12.2010 00:35, Carl-Daniel Hailfinger wrote:
Auf 22.12.2010 10:26, Mathias Krause schrieb:
Fix decoding of SB600 LPC ROM protection registers.
The address part was using a bit of the size, the size was missing the upper bit, was off by 1023 bytes and included the protection bits.
Signed-off-by: Mathias Krause <mathias.krause at secunet.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Do you have commit access?
Guess I've not (yet). So please go ahead and commit yourself. Thanks for the Ack! Regards, Mathias

On 23.12.2010 00:35, Carl-Daniel Hailfinger wrote:
Auf 22.12.2010 10:26, Mathias Krause schrieb:
Fix decoding of SB600 LPC ROM protection registers.
The address part was using a bit of the size, the size was missing the upper bit, was off by 1023 bytes and included the protection bits.
Signed-off-by: Mathias Krause <mathias.krause at secunet.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Do you have commit access?
Thanks! Committed as r1250. Regards, Mathias
participants (2)
-
Carl-Daniel Hailfinger
-
Mathias Krause