On 22.12.2010 02:33, Carl-Daniel Hailfinger wrote:
thanks for your patch.
Thanks for the review!
On 21.12.2010 16:17, Mathias Krause wrote:
(prot & 0xfffff800) + (((((prot & 0x7fc) >> 2) + 1) << 10) - 1));
This one looks a bit odd. How about
(prot & 0xfffff800) + ((((prot & 0x7fc) >> 2) << 10) | 0x3ff);
My solution really looks odd but how about that one:
(prot & 0xfffff800) + (((prot & 0x7fc) << 8) | 0x3ff));
New patch attached:
Fixed decoding of SB600 LPC ROM protection registers.
The address part was using a bit of the size, the size was missing the upper bit, was off by 1023 bytes and included the protection bits.
Signed-off-by: Mathias Krause <mathias.krause at secunet.com>