[PATCH] Add a board-enable for the ASRock K7S41, chipset-enable for SiS 741

[Uwe Hermann]

See patch.

I literally guessed this board-enable and was lucky at the very first try :)

Not sure if DMI matching is required (I guess it is), please let me know
if I should change that.

lspci/superiotool/flashrom -w are attached.

Uwe.

[Joshua Roys]

On 09/11/2010 12:09 PM, Uwe Hermann wrote:
> See patch.
>
> I literally guessed this board-enable and was lucky at the very first try :)
>
> Not sure if DMI matching is required (I guess it is), please let me know
> if I should change that.
>
> lspci/superiotool/flashrom -w are attached.
>
> Uwe.

Two things,

This one will conflict with:
http://patchwork.coreboot.org/patch/1927/

Other than that, if you're going to do DMI (which isn't strictly needed
right now- I don't see anything in board_enable.c we could conflict
with, but who knows in the future) I would just match on the SMBus even
though it doesn't have subsystem IDs.  That may be a personal preference
though, so feel free to disagree.

Josh

[Carl-Daniel Hailfinger]

On 11.09.2010 18:09, Uwe Hermann wrote:
> I literally guessed this board-enable and was lucky at the very first try :)
>
> Not sure if DMI matching is required (I guess it is), please let me know
> if I should change that.
>
> lspci/superiotool/flashrom -w are attached.

Could you add a link to the mail at flashrom.org with the logs? That
would be nice for people who go through the changelog and not the
mailing list.
> Add a board-enable for the ASRock K7S41, chipset-enable for SiS 741.
>
> This also adds (and marks as tested) a chipset-enable for the SiS 741.
>
> All operations successfully tested on hardware.
>
> Signed-off-by: Uwe Hermann

I agree with David Borg that we want the real fix (Super I/O
autodetection and auto-setup), but given that the Super I/O probing
needs to be revamped, I think this is a lower risk patch.

I want to merge David's patches directly after 0.9.3 is out, though:
[flashrom] [PATCH] W83697 superio safety checks
[flashrom] [PATCH] W83697xx superio flash enable
[flashrom] [Patch] Reduce usage of w836xx_memw

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[Uwe Hermann]

On Tue, Oct 05, 2010 at 11:35:02PM +0200, Carl-Daniel Hailfinger wrote:
> On 11.09.2010 18:09, Uwe Hermann wrote:
> > I literally guessed this board-enable and was lucky at the very first try :)
> >
> > Not sure if DMI matching is required (I guess it is), please let me know
> > if I should change that.
> >
> > lspci/superiotool/flashrom -w are attached.
>
> Could you add a link to the mail at flashrom.org with the logs? That
> would be nice for people who go through the changelog and not the
> mailing list.

Done.
> I agree with David Borg that we want the real fix (Super I/O
> autodetection and auto-setup), but given that the Super I/O probing
> needs to be revamped, I think this is a lower risk patch.
>
> I want to merge David's patches directly after 0.9.3 is out, though:
> [flashrom] [PATCH] W83697 superio safety checks
> [flashrom] [PATCH] W83697xx superio flash enable
> [flashrom] [Patch] Reduce usage of w836xx_memw

Yep, agreed.
> Acked-by: Carl-Daniel Hailfinger

Thanks, r1192.

Uwe.