Hi,
attached patch changes: - replace the hand written serial input flush routine with the termios one. - serialport_discard_read isn't necessary anymore - it just wrapped sp_flush_incoming with no extra value. - serialport_read and serialport_write would misbehave if read or write didn't process everything in one go.
All untested as I don't have a system where these are used. Just wanted these issues out in public.
Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Am 06.01.2010 17:58, schrieb Patrick Georgi:
Hi,
attached patch changes:
- replace the hand written serial input flush routine with the termios one.
- serialport_discard_read isn't necessary anymore - it just wrapped
sp_flush_incoming with no extra value.
- serialport_read and serialport_write would misbehave if read or write
didn't process everything in one go.
All untested as I don't have a system where these are used. Just wanted these issues out in public.
Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
Oops, some more issues to fix (patch above, plus...) : - serialport_read and serialport_write still didn't work properly. I really hope they will now. - sp_flush_incoming should be #define'd out for FAKE_COMMUNICATION like serialport_discard_read was
Still
Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de
On 06.01.2010 20:07, Sean Nelson wrote:
Acked-by: Sean Nelson audiohacked@gmail.com
r831.
Regards, Carl-Daniel