Re: [flashrom] [PATCH 02/10] Add support for AMD Geode's MSR on OpenBSD.

[Carl-Daniel Hailfinger]

Am 10.07.2013 21:17 schrieb Stefan Tauner:
> Previously the default implementation was used, which always failed.
> On other systems than the Geode the code is not equal to that anymore,
> but should not explode because setup_cpu_msr() returns an error and
> therefore no other MSR functions should be called.
>
> Signed-off-by: Stefan Tauner 
> Tested-by Leonardo Guardati 
> Acked-by: Stefan Tauner
>
> Signed-off-by: Stefan Tauner

Please kill one of your signoffs.

I like the simplification of the previous #ifdef mess.

Cosmetic suggestions (commit is OK without them as well):
Move the libpayload setup_cpu_msr/cleanup_cpu_msr from the top of the
file down to the block right after libpayload_wrmsr. This has the
advantage of making the msr setup code for libpayload dependent on x86
instead of having it enabled for all architectures.
Add a comment to the OSX MSR functions which mentions that rdmsr/wrmsr
are provided by DirectHW.

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH 02/10] Add support for AMD Geode's MSR on OpenBSD.

[Stefan Tauner]

On Sat, 13 Jul 2013 17:36:28 +0200
Carl-Daniel Hailfinger  wrote:
> Am 10.07.2013 21:17 schrieb Stefan Tauner:
> > Previously the default implementation was used, which always failed.
> > On other systems than the Geode the code is not equal to that anymore,
> > but should not explode because setup_cpu_msr() returns an error and
> > therefore no other MSR functions should be called.
> >
> > Signed-off-by: Stefan Tauner 
> > Tested-by Leonardo Guardati 
> > Acked-by: Stefan Tauner
> >
> > Signed-off-by: Stefan Tauner
>
> Please kill one of your signoffs.

That was git send-mail i think... you can ignore that.
> I like the simplification of the previous #ifdef mess.
>
> Cosmetic suggestions (commit is OK without them as well):
> Move the libpayload setup_cpu_msr/cleanup_cpu_msr from the top of the
> file down to the block right after libpayload_wrmsr. This has the
> advantage of making the msr setup code for libpayload dependent on x86
> instead of having it enabled for all architectures.

As discussed... in 3/10.
> Add a comment to the OSX MSR functions which mentions that rdmsr/wrmsr
> are provided by DirectHW.
>
> Acked-by: Carl-Daniel Hailfinger

Thanks, r1696.