Re: [flashrom] [PATCH] Fix SFDP probing.

[Carl-Daniel Hailfinger]

Am 22.02.2012 00:14 schrieb Stefan Tauner:
> sfdp_add_uniform_eraser checks for existing erasers. Due to a bug it
> looked for eraser slots that have no erase functions set instead of
> those that have one set.
>
> Postpone adding an erase function for the special 4k block erase
> opcode until we know the flash chip size and add an additional check
> to sfdp_add_uniform_eraser.
>
> Fix the output of the parameter table contents.
>
> This patch fixes the index used to retrieve the eraser types, which
> was off one double word.
>
> Refine some messages and add a few further debugging prints.
>
> Signed-off-by: Stefan Tauner

I assume this has been tested with the dummy simulator.
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH] Fix SFDP probing.

[Stefan Tauner]

On Wed, 22 Feb 2012 00:34:13 +0100
Carl-Daniel Hailfinger  wrote:
> Am 22.02.2012 00:14 schrieb Stefan Tauner:
> > sfdp_add_uniform_eraser checks for existing erasers. Due to a bug it
> > looked for eraser slots that have no erase functions set instead of
> > those that have one set.
> >
> > Postpone adding an erase function for the special 4k block erase
> > opcode until we know the flash chip size and add an additional check
> > to sfdp_add_uniform_eraser.
> >
> > Fix the output of the parameter table contents.
> >
> > This patch fixes the index used to retrieve the eraser types, which
> > was off one double word.
> >
> > Refine some messages and add a few further debugging prints.
> >
> > Signed-off-by: Stefan Tauner
>
> I assume this has been tested with the dummy simulator.

now it has been ;)
the only additional change i have made: i have indented the "It seems
like this chip supports the preliminary Intel version"…
> Acked-by: Carl-Daniel Hailfinger

thanks, committed in r1505. let's hope we have tackled everything. :)