Hello Flashrom dev team, I am LN and I wanted to know how to start with Easy Projects/contributions in this project . I found some (Easy Projects) https://ticket.coreboot.org/projects/flashrom/issues?utf8=%E2%9C%93&set_filter=1&sort=id%3Adesc&f%5B%5D=status_id&op%5Bstatus_id%5D=o&f%5B%5D=category_id&op%5Bcategory_id%5D=%3D&v%5Bcategory_id%5D%5B%5D=16&f%5B%5D=&c%5B%5D=tracker&c%5B%5D=status&c%5B%5D=priority&c%5B%5D=subject&c%5B%5D=assigned_to&c%5B%5D=updated_on&group_by=&t%5B%5D= on Coreboot webpage and I just wanted to know if the mentioned issues from the attached page have been resolved or if they are open for contribution? As I notice the ‘Turn variable is_laptop into an enum https://ticket.coreboot.org/issues/416’ issue is open on the Coreboot page and seems to be an easy issue to resolve yet it appears to be solved on this page https://review.coreboot.org/c/flashrom/+/66891. I will be happy if someone can point me towards more such issues that are beginner friendly or to a developer guide to set up my workspace and read more about the project structure and source code, and I appreciate your help 🙂.
Thanking you, LN
Hi there,
On Thu, 2022-09-22 at 21:09 +0530, Lakshminarayana Malyala wrote:
I am LN and I wanted to know how to start with Easy Projects/contributions in this project . I found some (Easy Projects) on Coreboot webpage and I just wanted to know if the mentioned issues from the attached page have been resolved or if they are open for contribution? As I notice the ‘Turn variable is_laptop into an enum’ issue is open on the Coreboot page and seems to be an easy issue to resolve yet it appears to be solved on this page.
The task is not resolved. Look again at the variable names. The variable mentioned in the ticket is named is_laptop, while the patch you mentioned modifies laptop_ok making use of the bool type.
Also, the task is to turn is_laptop into an enum and not bool.
I will be happy if someone can point me towards more such issues that are beginner friendly or to a developer guide to set up my workspace and read more about the project structure and source code, and I appreciate your help.
Please look at the development guidelines here https://www.flashrom.org/Development_Guidelines. Also look at the README and the document Documentation/building.md, which you can find in the repository.
// Felix
-
Felix Singer -
Lakshminarayana Malyala