Good day,
I wanted to confirm that we are splitting flashchips.c file into separate files per vendor. flashchips.c will still stay in the source code but it will be much smaller and will only contain "generic" chip entries.
The patch is here: https://review.coreboot.org/c/flashrom/+/83307 , it will be submitted after v1.5.0 tag is done. The patch will not be included in v1.5.0 release.
There will be no changes to the usage, and everything that's supported stays the same.
If you are a flashrom user who does not look into source code: this does not affect you at all.
If you are working on adding support for a chip model: when the patch is submitted (I will post again) you will need to copy your code from flashchips.c into a vendor-specific file. Thank you!
Update: this change is submitted.
On Fri, Nov 29, 2024 at 8:35 PM Anastasia Klimchuk aklm@chromium.org wrote:
Good day,
I wanted to confirm that we are splitting flashchips.c file into separate files per vendor. flashchips.c will still stay in the source code but it will be much smaller and will only contain "generic" chip entries.
The patch is here: https://review.coreboot.org/c/flashrom/+/83307 , it will be submitted after v1.5.0 tag is done. The patch will not be included in v1.5.0 release.
There will be no changes to the usage, and everything that's supported stays the same.
If you are a flashrom user who does not look into source code: this does not affect you at all.
If you are working on adding support for a chip model: when the patch is submitted (I will post again) you will need to copy your code from flashchips.c into a vendor-specific file. Thank you!
-- Anastasia.
-
Anastasia Klimchuk