[PATCH] Enable gfxnvidia, disallow write/erase

[Carl-Daniel Hailfinger]

Compile gfxnvidia by default, but disallow write/erase.
Needs [PATCH] Allow programmers to disallow writes

Signed-off-by: Carl-Daniel Hailfinger

Index: flashrom-gfxnvidia_enable_without_write/gfxnvidia.c
===================================================================
--- flashrom-gfxnvidia_enable_without_write/gfxnvidia.c	(Revision 1065)
+++ flashrom-gfxnvidia_enable_without_write/gfxnvidia.c	(Arbeitskopie)
@@ -75,6 +75,9 @@

buses_supported = CHIP_BUSTYPE_PARALLEL;

+	/* Write/erase doesn't work. */
+	programmer_may_write = 0;
+
    return 0;
 }

Index: flashrom-gfxnvidia_enable_without_write/Makefile
===================================================================
--- flashrom-gfxnvidia_enable_without_write/Makefile	(Revision 1065)
+++ flashrom-gfxnvidia_enable_without_write/Makefile	(Arbeitskopie)
@@ -113,8 +113,8 @@
 # Always enable 3Com NICs for now.
 CONFIG_NIC3COM ?= yes

-# Disable NVIDIA graphics cards for now, write/erase don't work properly.
-CONFIG_GFXNVIDIA ?= no
+# Enable NVIDIA graphics cards. Note: write/erase don't work properly.
+CONFIG_GFXNVIDIA ?= yes

# Always enable SiI SATA controllers for now.
 CONFIG_SATASII ?= yes

[Uwe Hermann]

On Thu, Jul 01, 2010 at 05:36:01PM +0200, Carl-Daniel Hailfinger wrote:
> Compile gfxnvidia by default, but disallow write/erase.
> Needs [PATCH] Allow programmers to disallow writes
>
> Signed-off-by: Carl-Daniel Hailfinger

Acked-by: Uwe Hermann

Fine for now, will do more testing as time permits, writing may actually
work, but with certain limitations.

Uwe.

[Carl-Daniel Hailfinger]

On 29.07.2010 15:50, Uwe Hermann wrote:
> On Thu, Jul 01, 2010 at 05:36:01PM +0200, Carl-Daniel Hailfinger wrote:
> > Compile gfxnvidia by default, but disallow write/erase.
> > Needs [PATCH] Allow programmers to disallow writes
> >
> > Signed-off-by: Carl-Daniel Hailfinger
>
> Acked-by: Uwe Hermann
>
> Fine for now, will do more testing as time permits, writing may actually
> work, but with certain limitations.

Thanks, I changed the wording in the Makefile slightly and committed in
r1117.

Regards,
Carl-Daniel