Here's support for Spansion S25FL004A, S25FL032A, and S25FL064A. I have tested all fuctions (probe, read, erase, and write) using a Bus Pirate on the S25FL064A and they were all successful. The S25FL004A and S25FL032A should work based on the values of the datasheets, but have not been tested.
Segfault
Hi Segfault,
thanks for your patch.
On 10.11.2010 00:44, Segfault wrote:
Here's support for Spansion S25FL004A, S25FL032A, and S25FL064A. I have tested all fuctions (probe, read, erase, and write) using a Bus Pirate on the S25FL064A and they were all successful. The S25FL004A and S25FL032A should work based on the values of the datasheets, but have not been tested.
I plan to apply your patch soon and want to make sure you're credited properly in the changelog. We use the same Signed-off-by procedure as the Linux kernel and coreboot: http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure Please reply-all to this mail with your signed-off-by line and I'll commit.
Regards, Carl-Daniel
Signed-off-by: Segfault segfault@committeeofdoom.com
On Tue, Nov 9, 2010 at 8:56 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
Hi Segfault,
thanks for your patch.
On 10.11.2010 00:44, Segfault wrote:
Here's support for Spansion S25FL004A, S25FL032A, and S25FL064A. I have tested all fuctions (probe, read, erase, and write) using a Bus Pirate on the S25FL064A and they were all successful. The S25FL004A and S25FL032A should work based on the values of the datasheets, but have not been tested.
I plan to apply your patch soon and want to make sure you're credited properly in the changelog. We use the same Signed-off-by procedure as the Linux kernel and coreboot: http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure Please reply-all to this mail with your signed-off-by line and I'll commit.
Regards, Carl-Daniel
Hi Segfault,
On 10.11.2010 04:07, Segfault wrote:
On Tue, Nov 9, 2010 at 8:56 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
We use the same Signed-off-by procedure as the Linux kernel and coreboot: http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
Signed-off-by: Segfault segfault@committeeofdoom.com
Is "Segfault" your official name or a stage name or religious name as mentioned in your ID documents? We try to have all commit records contain the official name (as found in the ID documents) of the contributor for legal reasons just in case someone claims that the history of our code is unknown. So far we know the real name of all contributors of all lines in our codebase.
Regards, Carl-Daniel
Signed-off-by: Rudy Host segfault@committeeofdoom.com
On Tue, Nov 9, 2010 at 9:55 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
Hi Segfault,
On 10.11.2010 04:07, Segfault wrote:
On Tue, Nov 9, 2010 at 8:56 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
We use the same Signed-off-by procedure as the Linux kernel and coreboot: http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
Signed-off-by: Segfault segfault@committeeofdoom.com
Is "Segfault" your official name or a stage name or religious name as mentioned in your ID documents? We try to have all commit records contain the official name (as found in the ID documents) of the contributor for legal reasons just in case someone claims that the history of our code is unknown. So far we know the real name of all contributors of all lines in our codebase.
Regards, Carl-Daniel
Any ETA on getting this committed? On Nov 10, 2010 11:11 AM, "Segfault" segfault@committeeofdoom.com wrote:
Signed-off-by: Rudy Host segfault@committeeofdoom.com
On Tue, Nov 9, 2010 at 9:55 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
Hi Segfault,
On 10.11.2010 04:07, Segfault wrote:
On Tue, Nov 9, 2010 at 8:56 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
We use the same Signed-off-by procedure as the Linux kernel and coreboot: http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
Signed-off-by: Segfault segfault@committeeofdoom.com
Is "Segfault" your official name or a stage name or religious name as mentioned in your ID documents? We try to have all commit records contain the official name (as found in the ID documents) of the contributor for legal reasons just in case someone claims that the history of our code is unknown. So far we know the real name of all contributors of all lines in our codebase.
Regards, Carl-Daniel
2010/11/10 Segfault segfault@committeeofdoom.com
Signed-off-by: Rudy Host segfault@committeeofdoom.com
Acked-by: Idwer Vollering vidwer@gmail.com
2010/11/19 Segfault segfault@committeeofdoom.com
Any ETA on getting this committed?
Usually patches like this are collected and committed as in combination with other patches/reports, e.g. http://flashrom.org/trac/flashrom/changeset/1129
On 10.11.2010 18:11, Segfault wrote:
Signed-off-by: Rudy Host segfault@committeeofdoom.com
Thanks for your patch!
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net and committed in r1237.
Sorry for the delay.
Regards, Carl-Daniel