This patch moves the current files into folders, library related in libflashrom/, CLI related in cli/, QT4 gui in qt4/. The Qt4.5 gui hasn't been integrated into the tree yet. Please review at your leisure. Yes, this is a very large patch.
Signed-off-by: Sean Nelson audiohacked@gmail.com
On 12.12.2009 01:46, Sean Nelson wrote:
This patch moves the current files into folders, library related in libflashrom/,
That's a long path. What about lib/ and should we separate programmer and chip stuff as well? Maybe lib/programmer/ and lib/chip/ or somesuch?
CLI related in cli/, QT4 gui in qt4/. The Qt4.5 gui hasn't been integrated into the tree yet. Please review at your leisure. Yes, this is a very large patch.
Signed-off-by: Sean Nelson audiohacked@gmail.com
This patch is >1 MB and pretty difficult to review. Can you regenerate the patch without the file moves or at least with each moves summarized as "move foo.c to bar/foo.c"? The categorization of files is highly non-trivial and I'd like us to get it right.
I think someone posted a "move to subdirectories" patch in the past and was shot down (too small benefit for a huge pain of dealing with multiple subdirectories).
My current plan is to keep everything in one directory for now and split the files according to function. The biggest offender in the "undefined mishmash of functionality" category is flashrom.c which should be split into CLI interface (maybe in cli.c), library stuff and "action" infrastructure. Well, right now I'd be happy if the CLI stuff would be moved out to a separate file in the same directory. That alone should give us a feeling for what we need to kill.
Any file moves (to subdirectories) will invalidate all pending patches, so I'd like to merge everything else before doing the move post 0.9.2 (if we can get consensus on the directories). File splits are localized enough to be mergeable, though.
Regards, Carl-Daniel
Yeah, forget about patch. There's a better way for us to progress to a library. The worst way is changing the file structure.
-
Carl-Daniel Hailfinger -
Sean Nelson