[Patch] Boards: Fix up several issues with nvidia_mcp_gpio_set.

[Luc Verhaegen]

Luc Verhaegen.

[Michael Karcher]

Am Montag, den 21.12.2009, 16:52 +0100 schrieb Luc Verhaegen:
>   if ((gpio < 0) || (gpio > 31)) {
>   if ((gpio < 0) || (gpio > 0x40)) {

Sorry, I have to reject this one too. gpio == 0x40 is most probably
invalid, as it would be gpio_base + 0x100. This should read "gpio >=
0x40".

Nacked-by: Michael Karcher
>       default:
>           fprintf(stderr,
>                   "\nERROR: no nVidia LPC/SMBus controller found.\n");
>           return -1;
>       }
>       break;

Maybe make that error message
"no supported nVidia LPC/SMBus controller found.\n"

Regards,
  Michael Karcher

[Patch] Boards: Fix up several issues with nvidia_mcp_gpio_set.

[Carl-Daniel Hailfinger]

On 21.12.2009 17:10, Michael Karcher wrote:
> Am Montag, den 21.12.2009, 16:52 +0100 schrieb Luc Verhaegen:
> >   if ((gpio < 0) || (gpio > 31)) {
> >   if ((gpio < 0) || (gpio > 0x40)) {
>
> Sorry, I have to reject this one too. gpio == 0x40 is most probably
> invalid, as it would be gpio_base + 0x100. This should read "gpio >=
> 0x40".
>
> Nacked-by: Michael Karcher
> >       default:
> >           fprintf(stderr,
> >                   "\nERROR: no nVidia LPC/SMBus controller found.\n");
> >           return -1;
> >       }
> >       break;
>
> Maybe make that error message
> "no supported nVidia LPC/SMBus controller found.\n"

Luc, could you resubmit with the review comments addressed? I'd like to
get this in. Thanks.

Regards,
Carl-Daniel

[Patch] Boards: Fix up several issues with nvidia_mcp_gpio_set.

[Luc Verhaegen]

On Thu, Jan 07, 2010 at 09:44:19PM +0100, Carl-Daniel Hailfinger wrote:
> On 21.12.2009 17:10, Michael Karcher wrote:
> > Am Montag, den 21.12.2009, 16:52 +0100 schrieb Luc Verhaegen:
> > >   if ((gpio < 0) || (gpio > 31)) {
> > >   if ((gpio < 0) || (gpio > 0x40)) {
> >
> > Sorry, I have to reject this one too. gpio == 0x40 is most probably
> > invalid, as it would be gpio_base + 0x100. This should read "gpio >=
> > 0x40".
> >
> > Nacked-by: Michael Karcher
> > >       default:
> > >           fprintf(stderr,
> > >                   "\nERROR: no nVidia LPC/SMBus controller found.\n");
> > >           return -1;
> > >       }
> > >       break;
> >
> > Maybe make that error message
> > "no supported nVidia LPC/SMBus controller found.\n"
>
> Luc, could you resubmit with the review comments addressed? I'd like to
> get this in. Thanks.
>
> Regards,
> Carl-Daniel

We resolved this from irc, and it was committed as r810.

Luc Verhaegen.