Re: [flashrom] [PATCH] flashrom.8: explain read accesses as part of the write operation

[Paul Menzel]

Dear Stefan,

Am Donnerstag, den 21.07.2011, 13:06 +0200 schrieb Stefan Tauner:
> Signed-off-by: Stefan Tauner
>
> flashrom.8 |   13 +++++++++----
>  1 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/flashrom.8 b/flashrom.8
> index 5b11f6e..3b7ad40 100644
> --- a/flashrom.8
> +++ b/flashrom.8
> @@ -44,7 +44,12 @@ Write
>  .B <file>
>  into flash ROM. This will first automatically
>  .B erase
> -the chip, then write to it.
> +the chip, then write to it. The chip is also read several times: first an

I would make a full stop after »times« and begin a new sentence.
> +in-memory backup is made for disaster recovery and to be able to skip regions
> +that are already equal to the image file. This copy is updated after each erase
> +block (in case of errors it is even re-read completely). After writing has

… block. (In case of ….)
> +finished and if verification is enabled, the whole flash is read out and

the whole flash ROM/chip

I do not know if there are guidelines for referring to the chip.
> +compared with the input image.
>  .TP
>  .B "-n, --noverify"
>  Skip the automatic verification of flash ROM contents after writing. Using this
> @@ -541,7 +546,7 @@ unusable unless you can desolder the flash chip and have a full flash chip
>  backup. This is caused by the embedded controller (EC) present in many laptops,
>  which interacts badly with any flash attempts. This is a hardware limitation
>  and flashrom will attempt to detect it and abort immediately for safety reasons.
> -.SH LICENCE
> +.SH LICENSE

Please commit that separately next time right ahead as trivial.
> .B flashrom
>  is covered by the GNU General Public License (GPL), version 2. Some files are
>  additionally available under the GPL (version 2, or any later version).
> @@ -623,6 +628,6 @@ some others, please see the flashrom svn changelog for details.
>  .br
>  All authors can be reached via email at .
>  .PP
> -This manual page was written by Uwe Hermann 
> -and Carl-Daniel Hailfinger.
> +This manual page was written by Uwe Hermann ,
> +Carl-Daniel Hailfinger and others.
>  It is licensed under the terms of the GNU GPL (version 2 or later).

Acked-by: Paul Menzel

Thanks,

Paul

[PATCH] flashrom.8: explain read accesses as part of the write operation

[Stefan Tauner]

On Thu, 21 Jul 2011 13:19:45 +0200
Paul Menzel  wrote:

hello paul and thanks for the review!
> > -.SH LICENCE
> > +.SH LICENSE
>
> Please commit that separately next time right ahead as trivial.

i dont like such mini commits because they clutter history and i
usually keep them in a special branch. in this case i spotted it when
preparing the submission, so i left it in there.
> > .B flashrom
> >  is covered by the GNU General Public License (GPL), version 2. Some files are
> >  additionally available under the GPL (version 2, or any later version).
> > @@ -623,6 +628,6 @@ some others, please see the flashrom svn changelog for details.
> >  .br
> >  All authors can be reached via email at .
> >  .PP
> > -This manual page was written by Uwe Hermann 
> > -and Carl-Daniel Hailfinger.
> > +This manual page was written by Uwe Hermann ,
> > +Carl-Daniel Hailfinger and others.
> >  It is licensed under the terms of the GNU GPL (version 2 or later).
>
> Acked-by: Paul Menzel

thanks! did you check the correctness of the facts i state too or
phrasing only?

[PATCH] flashrom.8: explain read accesses as part of the write operation

[Paul Menzel]

Am Donnerstag, den 21.07.2011, 15:02 +0200 schrieb Stefan Tauner:
> On Thu, 21 Jul 2011 13:19:45 +0200
> Paul Menzel  wrote:
>
> hello paul and thanks for the review!
> > > -.SH LICENCE
> > > +.SH LICENSE
> >
> > Please commit that separately next time right ahead as trivial.
>
> i dont like such mini commits because they clutter history and i
> usually keep them in a special branch. in this case i spotted it when
> preparing the submission, so i left it in there.
> > > .B flashrom
> > >  is covered by the GNU General Public License (GPL), version 2. Some files are
> > >  additionally available under the GPL (version 2, or any later version).
> > > @@ -623,6 +628,6 @@ some others, please see the flashrom svn changelog for details.
> > >  .br
> > >  All authors can be reached via email at .
> > >  .PP
> > > -This manual page was written by Uwe Hermann 
> > > -and Carl-Daniel Hailfinger.
> > > +This manual page was written by Uwe Hermann ,
> > > +Carl-Daniel Hailfinger and others.
> > >  It is licensed under the terms of the GNU GPL (version 2 or later).
> >
> > Acked-by: Paul Menzel
>
> thanks! did you check the correctness of the facts i state too or
> phrasing only?

Just the phrasing.

Thanks,

Paul