Re: [flashrom] [PATCH] make Makefile's test programs (more) -W safe

[Carl-Daniel Hailfinger]

Am 24.06.2011 19:10 schrieb Stefan Tauner:
> Signed-off-by: Stefan Tauner
>
> Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 3dda8c2..5cbe034 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -413,7 +413,7 @@ strip: $(PROGRAM)$(EXEC_SUFFIX)
>  compiler: featuresavailable
>    @printf "Checking for a C compiler... "
>    @$(shell ( echo "int main(int argc, char **argv)"; \
>    echo "{ return 0; }"; ) > .test.c )
>    echo "{ (void) argc; (void) argv; return 0; }"; ) > .test.c )
> @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .test.c -o .test$(EXEC_SUFFIX) >/dev/null &&	\
> echo "found." || ( echo "not found."; \
> rm -f .test.c .test$(EXEC_SUFFIX); exit 1)
>
> @@ -427,7 +427,7 @@ pciutils: compiler
>    	   echo "#include <pci/pci.h>";		   \
>    	   echo "struct pci_access *pacc;";	   \
>    	   echo "int main(int argc, char **argv)"; \
>    echo "{ pacc = pci_alloc(); return 0; }"; ) > .test.c )
>    echo "{ (void) argc; (void) argv; pacc = pci_alloc(); return 0; }"; ) > .test.c )
> @$(CC) -c $(CPPFLAGS) $(CFLAGS) .test.c -o .test.o >/dev/null 2>&1 &&		\
> echo "found." || ( echo "not found."; echo;			\
> echo "Please install libpci headers (package pciutils-devel).";	\

Ugh. Is this needed because some compiler complains about unused
parameters? If yes, can you add that information to the commit message?

That said, the same conversion is needed for CONFIG_FT2232_SPI=yes. If
you take care of all argc/argv cases, this is
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH] make Makefile's test programs (more) -W safe

[Stefan Tauner]

On Sun, 26 Jun 2011 19:33:24 +0200
Carl-Daniel Hailfinger  wrote:
> Am 24.06.2011 19:10 schrieb Stefan Tauner:
> > Signed-off-by: Stefan Tauner
> >
> > Makefile |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 3dda8c2..5cbe034 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -413,7 +413,7 @@ strip: $(PROGRAM)$(EXEC_SUFFIX)
> >  compiler: featuresavailable
> >    @printf "Checking for a C compiler... "
> >    @$(shell ( echo "int main(int argc, char **argv)"; \
> >    echo "{ return 0; }"; ) > .test.c )
> >    echo "{ (void) argc; (void) argv; return 0; }"; ) > .test.c )
> > @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .test.c -o .test$(EXEC_SUFFIX) >/dev/null &&	\
> > echo "found." || ( echo "not found."; \
> > rm -f .test.c .test$(EXEC_SUFFIX); exit 1)
> >
> > @@ -427,7 +427,7 @@ pciutils: compiler
> >    	   echo "#include <pci/pci.h>";		   \
> >    	   echo "struct pci_access *pacc;";	   \
> >    	   echo "int main(int argc, char **argv)"; \
> >    echo "{ pacc = pci_alloc(); return 0; }"; ) > .test.c )
> >    echo "{ (void) argc; (void) argv; pacc = pci_alloc(); return 0; }"; ) > .test.c )
> > @$(CC) -c $(CPPFLAGS) $(CFLAGS) .test.c -o .test.o >/dev/null 2>&1 &&		\
> > echo "found." || ( echo "not found."; echo;			\
> > echo "Please install libpci headers (package pciutils-devel).";	\
>
> Ugh. Is this needed because some compiler complains about unused
> parameters? If yes, can you add that information to the commit message?
>
> That said, the same conversion is needed for CONFIG_FT2232_SPI=yes. If
> you take care of all argc/argv cases, this is
> Acked-by: Carl-Daniel Hailfinger

nothing is broken currently. but if you add -W for testing purposes all the tests fail.
i have reworded the commit message and added all other compile programs to the patch.
committed in r1356.