Author: uwe Date: Sun Jan 31 21:13:06 2010 New Revision: 887 URL: http://flashrom.org/trac/coreboot/changeset/887
Log: Add the Tekram P6Pro-A5 board as supported (trivial).
The board doesn't need a board-enable, writing works out of the box.
Also, the board can only decode 256KB. I verified this by writing a 512KB image of random bytes (which fails), whereas 256KB of random bytes can be written correctly.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de Acked-by: Uwe Hermann uwe@hermann-uwe.de
Modified: trunk/board_enable.c trunk/print_wiki.c
Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Fri Jan 29 00:55:12 2010 (r886) +++ trunk/board_enable.c Sun Jan 31 21:13:06 2010 (r887) @@ -1235,6 +1235,7 @@ {0x10DE, 0x0050, 0x1297, 0x5036, 0x1412, 0x1724, 0x1297, 0x5036, NULL, NULL, NULL, "Shuttle", "FN25", 0, board_shuttle_fn25}, {0x1106, 0x3038, 0x0925, 0x1234, 0x1106, 0x3058, 0x15DD, 0x7609, NULL, NULL, NULL, "Soyo", "SY-7VCA", 0, board_soyo_sy_7vca}, {0x8086, 0x1076, 0x8086, 0x1176, 0x1106, 0x3059, 0x10f1, 0x2498, NULL, NULL, NULL, "Tyan", "S2498 (Tomcat K7M)", 0, w836xx_memw_enable_2e}, + {0x1106, 0x3038, 0x0925, 0x1234, 0, 0, 0, 0, NULL, NULL, NULL, "Tekram", "P6Pro-A5", 256, NULL}, {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, "VIA", "EPIA M/MII/...", 0, via_vt823x_gpio15_raise}, {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, "VIA", "EPIA-N/NL", 0, via_vt823x_gpio9_raise}, {0x1106, 0x5337, 0x1458, 0xb003, 0x1106, 0x287e, 0x1106, 0x337e, NULL, NULL, NULL, "VIA", "PC3500G", 0, it87xx_probe_spi_flash},
Modified: trunk/print_wiki.c ============================================================================== --- trunk/print_wiki.c Fri Jan 29 00:55:12 2010 (r886) +++ trunk/print_wiki.c Sun Jan 31 21:13:06 2010 (r887) @@ -167,6 +167,7 @@ { "RCA", "RM4100", "http://www.settoplinux.org/index.php?title=RCA_RM4100" }, { "Sun", "Blade x6250", "http://www.sun.com/servers/blades/x6250/" }, { "Supermicro", "H8QC8", "http://www.supermicro.com/Aplus/motherboard/Opteron/nforce/H8QC8.cfm" }, + { "Tekram", "P6Pro-A5", "http://www.motherboard.cz/mb/tekram/P6Pro-A5.htm" }, { "Thomson", "IP1000", "http://www.settoplinux.org/index.php?title=Thomson_IP1000" }, { "TriGem", "Lomita", "http://www.e4allupgraders.info/dir1/motherboards/socket370/lomita.shtml" }, { "T-Online", "S-100", "http://wiki.freifunk-hannover.de/T-Online_S_100" },
On Sun, Jan 31, 2010 at 09:13:07PM +0100, repository service wrote:
Author: uwe Date: Sun Jan 31 21:13:06 2010 New Revision: 887 URL: http://flashrom.org/trac/coreboot/changeset/887
Log: Add the Tekram P6Pro-A5 board as supported (trivial).
The board doesn't need a board-enable, writing works out of the box.
Also, the board can only decode 256KB. I verified this by writing a 512KB image of random bytes (which fails), whereas 256KB of random bytes can be written correctly.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de Acked-by: Uwe Hermann uwe@hermann-uwe.de
Modified: trunk/board_enable.c trunk/print_wiki.c
Modified: trunk/board_enable.c
--- trunk/board_enable.c Fri Jan 29 00:55:12 2010 (r886) +++ trunk/board_enable.c Sun Jan 31 21:13:06 2010 (r887) @@ -1235,6 +1235,7 @@ {0x10DE, 0x0050, 0x1297, 0x5036, 0x1412, 0x1724, 0x1297, 0x5036, NULL, NULL, NULL, "Shuttle", "FN25", 0, board_shuttle_fn25}, {0x1106, 0x3038, 0x0925, 0x1234, 0x1106, 0x3058, 0x15DD, 0x7609, NULL, NULL, NULL, "Soyo", "SY-7VCA", 0, board_soyo_sy_7vca}, {0x8086, 0x1076, 0x8086, 0x1176, 0x1106, 0x3059, 0x10f1, 0x2498, NULL, NULL, NULL, "Tyan", "S2498 (Tomcat K7M)", 0, w836xx_memw_enable_2e},
- {0x1106, 0x3038, 0x0925, 0x1234, 0, 0, 0, 0, NULL, NULL, NULL, "Tekram", "P6Pro-A5", 256, NULL}, {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, "VIA", "EPIA M/MII/...", 0, via_vt823x_gpio15_raise}, {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, "VIA", "EPIA-N/NL", 0, via_vt823x_gpio9_raise}, {0x1106, 0x5337, 0x1458, 0xb003, 0x1106, 0x287e, 0x1106, 0x337e, NULL, NULL, NULL, "VIA", "PC3500G", 0, it87xx_probe_spi_flash},
Second set of ids.
Luc Verhaegen.
On Sun, Jan 31, 2010 at 10:27:35PM +0100, Luc Verhaegen wrote:
On Sun, Jan 31, 2010 at 09:13:07PM +0100, repository service wrote:
Author: uwe Date: Sun Jan 31 21:13:06 2010 New Revision: 887 URL: http://flashrom.org/trac/coreboot/changeset/887
Log: Add the Tekram P6Pro-A5 board as supported (trivial).
The board doesn't need a board-enable, writing works out of the box.
Also, the board can only decode 256KB. I verified this by writing a 512KB image of random bytes (which fails), whereas 256KB of random bytes can be written correctly.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de Acked-by: Uwe Hermann uwe@hermann-uwe.de
Modified: trunk/board_enable.c trunk/print_wiki.c
Modified: trunk/board_enable.c
--- trunk/board_enable.c Fri Jan 29 00:55:12 2010 (r886) +++ trunk/board_enable.c Sun Jan 31 21:13:06 2010 (r887) @@ -1235,6 +1235,7 @@ {0x10DE, 0x0050, 0x1297, 0x5036, 0x1412, 0x1724, 0x1297, 0x5036, NULL, NULL, NULL, "Shuttle", "FN25", 0, board_shuttle_fn25}, {0x1106, 0x3038, 0x0925, 0x1234, 0x1106, 0x3058, 0x15DD, 0x7609, NULL, NULL, NULL, "Soyo", "SY-7VCA", 0, board_soyo_sy_7vca}, {0x8086, 0x1076, 0x8086, 0x1176, 0x1106, 0x3059, 0x10f1, 0x2498, NULL, NULL, NULL, "Tyan", "S2498 (Tomcat K7M)", 0, w836xx_memw_enable_2e},
- {0x1106, 0x3038, 0x0925, 0x1234, 0, 0, 0, 0, NULL, NULL, NULL, "Tekram", "P6Pro-A5", 256, NULL}, {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, "VIA", "EPIA M/MII/...", 0, via_vt823x_gpio15_raise}, {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, "VIA", "EPIA-N/NL", 0, via_vt823x_gpio9_raise}, {0x1106, 0x5337, 0x1458, 0xb003, 0x1106, 0x287e, 0x1106, 0x337e, NULL, NULL, NULL, "VIA", "PC3500G", 0, it87xx_probe_spi_flash},
Second set of ids.
Luc Verhaegen.
Also, where are the lspci -vvnnxxx; flashrom -V and superio -deV outputs that we require for board enables? I seem unable to find them on the list.
Luc Verhaegen.
On Mon, Feb 01, 2010 at 02:53:30AM +0100, Luc Verhaegen wrote:
On Sun, Jan 31, 2010 at 10:27:35PM +0100, Luc Verhaegen wrote:
On Sun, Jan 31, 2010 at 09:13:07PM +0100, repository service wrote:
Author: uwe Date: Sun Jan 31 21:13:06 2010 New Revision: 887 URL: http://flashrom.org/trac/coreboot/changeset/887
Log: Add the Tekram P6Pro-A5 board as supported (trivial).
The board doesn't need a board-enable, writing works out of the box.
Also, the board can only decode 256KB. I verified this by writing a 512KB image of random bytes (which fails), whereas 256KB of random bytes can be written correctly.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de Acked-by: Uwe Hermann uwe@hermann-uwe.de
Modified: trunk/board_enable.c trunk/print_wiki.c
Modified: trunk/board_enable.c
--- trunk/board_enable.c Fri Jan 29 00:55:12 2010 (r886) +++ trunk/board_enable.c Sun Jan 31 21:13:06 2010 (r887) @@ -1235,6 +1235,7 @@ {0x10DE, 0x0050, 0x1297, 0x5036, 0x1412, 0x1724, 0x1297, 0x5036, NULL, NULL, NULL, "Shuttle", "FN25", 0, board_shuttle_fn25}, {0x1106, 0x3038, 0x0925, 0x1234, 0x1106, 0x3058, 0x15DD, 0x7609, NULL, NULL, NULL, "Soyo", "SY-7VCA", 0, board_soyo_sy_7vca}, {0x8086, 0x1076, 0x8086, 0x1176, 0x1106, 0x3059, 0x10f1, 0x2498, NULL, NULL, NULL, "Tyan", "S2498 (Tomcat K7M)", 0, w836xx_memw_enable_2e},
- {0x1106, 0x3038, 0x0925, 0x1234, 0, 0, 0, 0, NULL, NULL, NULL, "Tekram", "P6Pro-A5", 256, NULL}, {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, "VIA", "EPIA M/MII/...", 0, via_vt823x_gpio15_raise}, {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, "VIA", "EPIA-N/NL", 0, via_vt823x_gpio9_raise}, {0x1106, 0x5337, 0x1458, 0xb003, 0x1106, 0x287e, 0x1106, 0x337e, NULL, NULL, NULL, "VIA", "PC3500G", 0, it87xx_probe_spi_flash},
Second set of ids.
Luc Verhaegen.
Also, where are the lspci -vvnnxxx; flashrom -V and superio -deV outputs that we require for board enables? I seem unable to find them on the list.
Luc Verhaegen.
This is fair warning from the board enable gestapo.
There are issues with this code: * no second set of IDs. * no lspci dump. * no superiotool dump. * no flashrom -V output for dmi strings.
This pretty much breaches all existing board enable conventions. This is exacerbated by the self-ack.
It is code from sunday, the issues here were flagged shortly after, but are still not rectified. I therefor propose a direct revert of the board enable line.
Luc Verhaegen.
On Thu, Feb 04, 2010 at 03:32:34AM +0100, Luc Verhaegen wrote:
On Mon, Feb 01, 2010 at 02:53:30AM +0100, Luc Verhaegen wrote:
On Sun, Jan 31, 2010 at 10:27:35PM +0100, Luc Verhaegen wrote:
On Sun, Jan 31, 2010 at 09:13:07PM +0100, repository service wrote:
Author: uwe Date: Sun Jan 31 21:13:06 2010 New Revision: 887 URL: http://flashrom.org/trac/coreboot/changeset/887
Log: Add the Tekram P6Pro-A5 board as supported (trivial).
The board doesn't need a board-enable, writing works out of the box.
Also, the board can only decode 256KB. I verified this by writing a 512KB image of random bytes (which fails), whereas 256KB of random bytes can be written correctly.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de Acked-by: Uwe Hermann uwe@hermann-uwe.de
Modified: trunk/board_enable.c trunk/print_wiki.c
Modified: trunk/board_enable.c
--- trunk/board_enable.c Fri Jan 29 00:55:12 2010 (r886) +++ trunk/board_enable.c Sun Jan 31 21:13:06 2010 (r887) @@ -1235,6 +1235,7 @@ {0x10DE, 0x0050, 0x1297, 0x5036, 0x1412, 0x1724, 0x1297, 0x5036, NULL, NULL, NULL, "Shuttle", "FN25", 0, board_shuttle_fn25}, {0x1106, 0x3038, 0x0925, 0x1234, 0x1106, 0x3058, 0x15DD, 0x7609, NULL, NULL, NULL, "Soyo", "SY-7VCA", 0, board_soyo_sy_7vca}, {0x8086, 0x1076, 0x8086, 0x1176, 0x1106, 0x3059, 0x10f1, 0x2498, NULL, NULL, NULL, "Tyan", "S2498 (Tomcat K7M)", 0, w836xx_memw_enable_2e},
- {0x1106, 0x3038, 0x0925, 0x1234, 0, 0, 0, 0, NULL, NULL, NULL, "Tekram", "P6Pro-A5", 256, NULL}, {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, "VIA", "EPIA M/MII/...", 0, via_vt823x_gpio15_raise}, {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, "VIA", "EPIA-N/NL", 0, via_vt823x_gpio9_raise}, {0x1106, 0x5337, 0x1458, 0xb003, 0x1106, 0x287e, 0x1106, 0x337e, NULL, NULL, NULL, "VIA", "PC3500G", 0, it87xx_probe_spi_flash},
Second set of ids.
Luc Verhaegen.
Also, where are the lspci -vvnnxxx; flashrom -V and superio -deV outputs that we require for board enables? I seem unable to find them on the list.
Luc Verhaegen.
This is fair warning from the board enable gestapo.
There are issues with this code:
- no second set of IDs.
- no lspci dump.
- no superiotool dump.
- no flashrom -V output for dmi strings.
This pretty much breaches all existing board enable conventions. This is exacerbated by the self-ack.
It is code from sunday, the issues here were flagged shortly after, but are still not rectified. I therefor propose a direct revert of the board enable line.
Luc Verhaegen.
Ok, seems to have been fixed in r890 now.
I still haven't see an lspci dump and at least flashrom -V output.
Luc Verhaegen.
On Mon, Feb 01, 2010 at 02:53:30AM +0100, Luc Verhaegen wrote:
Add the Tekram P6Pro-A5 board as supported (trivial).
The board doesn't need a board-enable, writing works out of the box.
Also, the board can only decode 256KB. I verified this by writing a 512KB image of random bytes (which fails), whereas 256KB of random bytes can be written correctly.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de Acked-by: Uwe Hermann uwe@hermann-uwe.de
Modified: trunk/board_enable.c trunk/print_wiki.c
Modified: trunk/board_enable.c
--- trunk/board_enable.c Fri Jan 29 00:55:12 2010 (r886) +++ trunk/board_enable.c Sun Jan 31 21:13:06 2010 (r887) @@ -1235,6 +1235,7 @@ {0x10DE, 0x0050, 0x1297, 0x5036, 0x1412, 0x1724, 0x1297, 0x5036, NULL, NULL, NULL, "Shuttle", "FN25", 0, board_shuttle_fn25}, {0x1106, 0x3038, 0x0925, 0x1234, 0x1106, 0x3058, 0x15DD, 0x7609, NULL, NULL, NULL, "Soyo", "SY-7VCA", 0, board_soyo_sy_7vca}, {0x8086, 0x1076, 0x8086, 0x1176, 0x1106, 0x3059, 0x10f1, 0x2498, NULL, NULL, NULL, "Tyan", "S2498 (Tomcat K7M)", 0, w836xx_memw_enable_2e},
- {0x1106, 0x3038, 0x0925, 0x1234, 0, 0, 0, 0, NULL, NULL, NULL, "Tekram", "P6Pro-A5", 256, NULL}, {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, "VIA", "EPIA M/MII/...", 0, via_vt823x_gpio15_raise}, {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, "VIA", "EPIA-N/NL", 0, via_vt823x_gpio9_raise}, {0x1106, 0x5337, 0x1458, 0xb003, 0x1106, 0x287e, 0x1106, 0x337e, NULL, NULL, NULL, "VIA", "PC3500G", 0, it87xx_probe_spi_flash},
Second set of ids.
Luc Verhaegen.
Also, where are the lspci -vvnnxxx; flashrom -V and superio -deV outputs that we require for board enables? I seem unable to find them on the list.
Thanks for the reminder. Second set of PCI IDs is now added in r890. I added dump support for the Super I/O in superiotool today, 'superiotool -deV' output as well as 'lspci -xxxvvvnnn' and 'flashrom -V' are attached.
Uwe.
On Thu, Feb 04, 2010 at 03:43:21AM +0100, Uwe Hermann wrote:
00:00.0 Host bridge [0600]: VIA Technologies, Inc. VT82C693A/694x [Apollo PRO133x] [1106:0691] (rev 01)
00:01.0 PCI bridge [0604]: VIA Technologies, Inc. VT82C598/694x [Apollo MVP3/Pro133x AGP] [1106:8598] (prog-if 00 [Normal decode])
00:07.0 ISA bridge [0601]: VIA Technologies, Inc. VT82C596 ISA [Mobile South] [1106:0596] (rev 06) Subsystem: VIA Technologies, Inc. VT82C596/A/B PCI to ISA Bridge [1106:0000]
00:07.1 IDE interface [0101]: VIA Technologies, Inc. VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE [1106:0571] (rev 06) (prog-if 8a [Master SecP PriP])
00:07.2 USB Controller [0c03]: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller [1106:3038] (rev 02) (prog-if 00 [UHCI]) Subsystem: First International Computer, Inc. VA-502 Mainboard [0925:1234]
This is a subsystem id which was submitted to pciids.sf.net, and is then per definition not unique.
00:07.3 Host bridge [0600]: VIA Technologies, Inc. VT82C596 Power Management [1106:3050]
Our match is not unique.
Found Winbond W83877AF (id=0x0b) at 0x3f0 Register dump: idx 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f 10 11 12 13 14 15 16 17 1e 20 21 22 23 24 25 26 27 28 29 2a 2b 2c 2d val 0c 00 02 50 44 00 00 0b 00 8b 1f 0c 28 ab 00 ff 00 00 00 00 00 00 07 00 00 fc 00 01 de fe be 23 25 43 60 00 00 10 2d def 00 00 00 30 00 00 00 00 00 0a 1f 0c 28 a3 RR RR 00 00 00 00 00 00 0e 00 MM MM MM MM MM MM MM MM MM MM MM MM MM MM MM Hardware monitor (0x0004)
Aha, need to add detection for this one too in my "if i ever get to finishing that" superio code :)
DMI string 0: "VIA Technologies, Inc." DMI string 1: "VT82C691" DMI string 2: " " DMI string 3: "Tekram Technology Co., Ltd." DMI string 4: "P6PROA5" DMI string 5: "Rev. 1.0"
We need to add a DMI string, and luckily, today, we can :)
Please add "^P6PROA5$" in the dmi field to make this match unique.
Trivial change, please test, then you have:
Acked-by: Luc Verhaegen libv@skynet.be
Luc Verhaegen.
-
Luc Verhaegen -
repository service -
Uwe Hermann