Re: [flashrom] [PATCH 1/4] ichspi.c: refactor filling and reading the fdata/spid registers

[Carl-Daniel Hailfinger]

Hi,

is there any reason why this is not committed yet?

Regards,
Carl-Daniel

Am 16.07.2011 04:17 schrieb Stefan Tauner:
> add ich_fill_data to fill the chipset registers from an array
> add ich_read_data to copy the data from the chipset register into an array
> replace the existing code with calls to those functions
> minor cosmetic changes
>
> Signed-off-by: Stefan Tauner 
> Acked-by: Carl-Daniel Hailfinger

[PATCH 1/4] ichspi.c: refactor filling and reading the fdata/spid registers

[Stefan Tauner]

On Sat, 16 Jul 2011 23:19:32 +0200
Carl-Daniel Hailfinger  wrote:
> is there any reason why this is not committed yet?

jup... as i explained in the cover letter of 7.0, i want to test it
first; especially because it wont get tested a lot before the 0.9.4
release. feel free to commit it yourself, if there is a reason to get
it in quickly, or ping me to do it.

david: if you read this: besides the normal patterns, we are interested
in cases of reads and writes that are not aligned to 32b words, also or
even more important in swseq not only in hwseq.

[PATCH 1/4] ichspi.c: refactor filling and reading the fdata/spid registers

[Carl-Daniel Hailfinger]

Am 17.07.2011 00:09 schrieb Stefan Tauner:
> On Sat, 16 Jul 2011 23:19:32 +0200
> Carl-Daniel Hailfinger  wrote:
> > is there any reason why this is not committed yet?
>
> jup... as i explained in the cover letter of 7.0, i want to test it
> first; especially because it wont get tested a lot before the 0.9.4
> release. feel free to commit it yourself, if there is a reason to get
> it in quickly, or ping me to do it.

OK, then I'm fine with moving it to post 0.9.4. I just thought you were
waiting for another ack from me or something similar.

Thanks for exercising caution before the 0.9.4 release.

Regards,
Carl-Daniel