Re: [flashrom] [PATCH] chipset_enable.c: add a message in the case the chipset enable is untested

[Paul Menzel]

Am Donnerstag, den 21.07.2011, 14:23 +0200 schrieb Stefan Tauner:
> old output:
> Calibrating delay loop... OK.
> Found chipset "Intel QS57", enabling flash write... OK.
> This chipset supports the following protocols: FWH, SPI.
>
> new non-verbose output for tested chipsets:
> Calibrating delay loop... OK.
> Found chipset "Intel QS57". Enabling flash write... OK.
> This chipset supports the following protocols: FWH, SPI.
>
> new non-verbose output for untested chipsets:
> Found chipset "Intel QS57".
> This chipset is marked as untested. If you are using an up-to-date version
> of flashrom please email a report to [e-mail] including a
> verbose (-V) log. Thank you!

A similar message should be shown somewhere else. I would put more
information in it.

This chipset is marked as untested. If you are using an up-to-date
version of flashrom http://flashrom.org/Downloads please email a
report to [e-mail] with the subject (variable with the name
(here Intel QS57) including a verbose (-V) log. Thank you!

Do we have preferences if the log should be pasted or attached?
> Enabling flash write... OK.
> This chipset supports the following protocols: FWH, SPI.
> Signed-off-by: Stefan Tauner
>
> chipset_enable.c |   19 ++++++++++++++-----
>  1 files changed, 14 insertions(+), 5 deletions(-)

[…]

Thanks,

Paul

[PATCH] chipset_enable.c: add a message in the case the chipset enable is untested

[Stefan Tauner]

On Thu, 21 Jul 2011 16:48:33 +0200
Paul Menzel  wrote:
> Am Donnerstag, den 21.07.2011, 14:23 +0200 schrieb Stefan Tauner:
> > old output:
> > Calibrating delay loop... OK.
> > Found chipset "Intel QS57", enabling flash write... OK.
> > This chipset supports the following protocols: FWH, SPI.
> >
> > new non-verbose output for tested chipsets:
> > Calibrating delay loop... OK.
> > Found chipset "Intel QS57". Enabling flash write... OK.
> > This chipset supports the following protocols: FWH, SPI.
> >
> > new non-verbose output for untested chipsets:
> > Found chipset "Intel QS57".
> > This chipset is marked as untested. If you are using an up-to-date version
> > of flashrom please email a report to [e-mail] including a
> > verbose (-V) log. Thank you!
>
> A similar message should be shown somewhere else.

hm?
> I would put more
> information in it.
>
> This chipset is marked as untested. If you are using an up-to-date
> version of flashrom http://flashrom.org/Downloads please email a
> report to [e-mail] with the subject (variable with the name
> (here Intel QS57) including a verbose (-V) log. Thank you!

i prefer shorter messages, because i hope they get read then. the
untested flash chip message is much longer with information in it like
you suggested... and the ratio of users that obey all our wishes are way
below 50%... i am happy if they manage to send us a verbose log in any
way :)
> Do we have preferences if the log should be pasted or attached?

for single logs inline is better, but i dont really care... as long as
they are not compressed.

thanks for your input.

[PATCH] chipset_enable.c: add a message in the case the chipset enable is untested

[Paul Menzel]

Am Donnerstag, den 21.07.2011, 22:15 +0200 schrieb Stefan Tauner:
> On Thu, 21 Jul 2011 16:48:33 +0200
> Paul Menzel  wrote:
> > Am Donnerstag, den 21.07.2011, 14:23 +0200 schrieb Stefan Tauner:
> > > old output:
> > > Calibrating delay loop... OK.
> > > Found chipset "Intel QS57", enabling flash write... OK.
> > > This chipset supports the following protocols: FWH, SPI.
> > >
> > > new non-verbose output for tested chipsets:
> > > Calibrating delay loop... OK.
> > > Found chipset "Intel QS57". Enabling flash write... OK.
> > > This chipset supports the following protocols: FWH, SPI.
> > >
> > > new non-verbose output for untested chipsets:
> > > Found chipset "Intel QS57".
> > > This chipset is marked as untested. If you are using an up-to-date version
> > > of flashrom please email a report to [e-mail] including a
> > > verbose (-V) log. Thank you!
> >
> > A similar message should be shown somewhere else.
>
> hm?

I forgot … should be shown somewhere else *already*.

For example in `flashrom.c`.

/* FIXME: This message is designed towards CLI users. */
    	msg_cinfo("The test status of this chip may have been updated "
    		    "in the latest development\n"
    		  "version of flashrom. If you are running the latest "
    		    "development version,\n"
    		  "please email a report to [e-mail] if "
    		    "any of the above operations\n"
    		  "work correctly for you with this flash part. Please "
    		    "include the flashrom\n"
    		  "output with the additional -V option for all "
    		    "operations you tested (-V, -Vr,\n"
    		  "-Vw, -VE), and mention which mainboard or "
    		    "programmer you tested. Please mention your board in "
    		  "the subject line.\n"
    		  "Thanks for your help!\n"
    		  "===\n");
> > I would put more information in it.
> >
> > This chipset is marked as untested. If you are using an up-to-date
> > version of flashrom http://flashrom.org/Downloads please email a
> > report to [e-mail] with the subject (variable with the name
> > (here Intel QS57) including a verbose (-V) log. Thank you!
>
> i prefer shorter messages, because i hope they get read then.

Have you heard somebody complain about that? People willing to help will
read one more sentence in my opinion.
> the untested flash chip message is much longer with information in it like
> you suggested... and the ratio of users that obey all our wishes are way
> below 50%... i am happy if they manage to send us a verbose log in any
> way :)

If the subject line is printed the way we want it, then they just copy
it.
> > Do we have preferences if the log should be pasted or attached?
>
> for single logs inline is better, but i dont really care... as long as
> they are not compressed.

Well then, it could be »… email a report to 
pasting the verbose log …«
> thanks for your input.

Thanks,

Paul