[PATCH] Intel Poulsbo chipset support

[Adam Jurkowski]

Add support for Intel Poulsbo chipset.

Signed-off-by: Adam Jurkowski

[Carl-Daniel Hailfinger]

Hi Adam,

thanks for your patch.

On 02.12.2009 16:34, Adam Jurkowski wrote:
> Add support for Intel Poulsbo chipset.
>
> Signed-off-by: Adam Jurkowski

Is there any reason you can't call enable_flash_ich(dev, name, 0xd8)?
That would eliminate some of the code.

Regards,
Carl-Daniel

[Adam Jurkowski]

Hi Carl-Daniel,

On 2009-12-02 16:51, Carl-Daniel Hailfinger wrote:
> Is there any reason you can't call enable_flash_ich(dev, name, 0xd8)?
> That would eliminate some of the code.

It's a matter of taste actually.

Using enable_flash_ich would eliminate only printf_debug lines and half 
of one PCI register value modification.

If I do all inside the function then I use word-access once instead of 
using byte-access twice.
I'm also able to print out the state of prefetch_flag right after 
lock_enable and write_enable but before the whole 16-bit register value.

Best regards,
Adam

[PATCH] Intel Poulsbo chipset support v2

[Adam Jurkowski]

On 2009-12-02 16:51, Carl-Daniel Hailfinger wrote:
> Hi Adam,
>
> thanks for your patch.
>
> On 02.12.2009 16:34, Adam Jurkowski wrote:
> > Add support for Intel Poulsbo chipset.
> >
> > Signed-off-by: Adam Jurkowski
>
> Is there any reason you can't call enable_flash_ich(dev, name, 0xd8)?
> That would eliminate some of the code.

Now enable_flash_ich is re-used.
I've also removed IDSEL and BDE register changing part. It was useful 
only for the case when default register values was modified.

Best regards,
Adam

[PATCH] Intel Poulsbo chipset support v2

[Adam Jurkowski]

No response since 2 weeks...

Does it mean nobody except us needs support for Intel Poulsbo (SCH) chipset?

Adam

On 2009-12-07 15:03, Adam Jurkowski wrote:
> On 2009-12-02 16:51, Carl-Daniel Hailfinger wrote:
> > Hi Adam,
> >
> > thanks for your patch.
> >
> > On 02.12.2009 16:34, Adam Jurkowski wrote:
> > > Add support for Intel Poulsbo chipset.
> > >
> > > Signed-off-by: Adam Jurkowski
> >
> > Is there any reason you can't call enable_flash_ich(dev, name, 0xd8)?
> > That would eliminate some of the code.
>
> Now enable_flash_ich is re-used.
> I've also removed IDSEL and BDE register changing part. It was useful 
> only for the case when default register values was modified.
>
> Best regards,
> Adam
>
> flashrom mailing list
> [e-mail]
> http://www.flashrom.org/mailman/listinfo/flashrom

[PATCH] Intel Poulsbo chipset support v2

[Luc Verhaegen]

On Mon, Dec 21, 2009 at 04:14:37PM +0100, Adam Jurkowski wrote:
> No response since 2 weeks...
>
> Does it mean nobody except us needs support for Intel Poulsbo (SCH) chipset?
>
> Adam

Pushed.

Sorry for the delay.

Luc Verhaegen.

[PATCH] Intel Poulsbo chipset support v2

[Carl-Daniel Hailfinger]

On 21.12.2009 16:37, Luc Verhaegen wrote:
> On Mon, Dec 21, 2009 at 04:14:37PM +0100, Adam Jurkowski wrote:
> > No response since 2 weeks...
> >
> > Does it mean nobody except us needs support for Intel Poulsbo (SCH) chipset?
> >
> > Adam
>
> Pushed.

This was r809.

Regards,
Carl-Daniel