commit 845 is wrong, as I deleted a wrong line when I wanted to remove debugging print code. This (hopefully obviously correct) patch fixes the issue. As a previous version (before adding the debugging statement) was already executed on the board, the missing OUTW was executed on the testers machine on an earlier flashrom run.
Regards, Michael Karcher
Index: board_enable.c =================================================================== --- board_enable.c (Revision 845) +++ board_enable.c (Arbeitskopie) @@ -967,7 +967,7 @@ base = pci_read_word(dev, 0x74); temp = INW(base + 0x68); temp &= ~(1 << 0); /* Make pin output? */ - printf_debug("changed to %04x\n",temp); + OUTW(temp, base + 0x68);
temp = INW(base + 0x64); temp |= (1 << 0); /* Raise output? */
On Sat, Jan 09, 2010 at 07:29:48PM +0100, Michael Karcher wrote:
commit 845 is wrong, as I deleted a wrong line when I wanted to remove debugging print code. This (hopefully obviously correct) patch fixes the issue. As a previous version (before adding the debugging statement) was already executed on the board, the missing OUTW was executed on the testers machine on an earlier flashrom run.
Regards, Michael Karcher
Index: board_enable.c
--- board_enable.c (Revision 845) +++ board_enable.c (Arbeitskopie) @@ -967,7 +967,7 @@ base = pci_read_word(dev, 0x74); temp = INW(base + 0x68); temp &= ~(1 << 0); /* Make pin output? */
- printf_debug("changed to %04x\n",temp);
OUTW(temp, base + 0x68);
temp = INW(base + 0x64); temp |= (1 << 0); /* Raise output? */
Acked-by: Luc Verhaegen libv@skynet.be
Luc Verhaegen.
Am Samstag, den 09.01.2010, 23:49 +0100 schrieb Luc Verhaegen:
On Sat, Jan 09, 2010 at 07:29:48PM +0100, Michael Karcher wrote:
commit 845 is wrong, as I deleted a wrong line when I wanted to remove debugging print code. This (hopefully obviously correct) patch fixes the
[...]
- printf_debug("changed to %04x\n",temp);
- OUTW(temp, base + 0x68);
Acked-by: Luc Verhaegen libv@skynet.be
Thank you. r846
Regards, Michael Karcher
-
Luc Verhaegen -
Michael Karcher