Re: [flashrom] [PATCH] Add support for S25FL128P and S25FL128P......0 chips.

[Stefan Tauner]

On Sat, 31 May 2014 23:07:35 +0200
Stefan Tauner  wrote:
> S25FL128P is the predecessor family of S25FL128S. All these chips can
> not be distinguished without EDI.
>
> Additionally to the new S25FL128P chips, this patch also fixes the name of
> the previously supported S25FL128S model with uniform 256 kB sectors
> (S25FL128P......1 not 0) and adds the hybrid sector version as well.
> Signed-off-by: Stefan Tauner
>
> Since flashrom can not distinguish the chips itself, the user has to
> select the right chip with the -c parameter.
>
> Liviu, please apply this patch on top of r1806 and run flashrom once
> without any operation and without -c ....
> E.g. flashrom -p usbblaster_spi -o probe.log
>
> And a second time with the correct chip selected to write *different* data
> to the chip.
> E.g. flashrom -p usbblaster_spi -o write.log -w newdata.bin -c "S25FL128P......0"
>
> Please report back with the two log files.

Hi Liviu,

are you gonna test this patch? If not I would like to commit it
untested so that it does not become outdated.

[PATCH] Add support for S25FL128P and S25FL128P......0 chips.

[Liviu Toma]

Hi Stefan,

I apologize I didn't have a chance to try it. I am just trying it now, I
will report a bit later

Liviu

On Thu, Jun 12, 2014 at 7:00 PM, Stefan Tauner <
[e-mail]> wrote:
> On Sat, 31 May 2014 23:07:35 +0200
> Stefan Tauner  wrote:
> > S25FL128P is the predecessor family of S25FL128S. All these chips can
> > not be distinguished without EDI.
> >
> > Additionally to the new S25FL128P chips, this patch also fixes the name
>
> of
> > the previously supported S25FL128S model with uniform 256 kB sectors
> > (S25FL128P......1 not 0) and adds the hybrid sector version as well.
> > Signed-off-by: Stefan Tauner
> >
> > Since flashrom can not distinguish the chips itself, the user has to
> > select the right chip with the -c parameter.
> >
> > Liviu, please apply this patch on top of r1806 and run flashrom once
> > without any operation and without -c ....
> > E.g. flashrom -p usbblaster_spi -o probe.log
> >
> > And a second time with the correct chip selected to write *different*
>
> data
> > to the chip.
> > E.g. flashrom -p usbblaster_spi -o write.log -w newdata.bin -c
>
> "S25FL128P......0"
> > Please report back with the two log files.
>
> Hi Liviu,
>
> are you gonna test this patch? If not I would like to commit it
> untested so that it does not become outdated.