Add board enable for EPoX EP-8NPA7I (and possibly other similar EPoX boards). Also, spelling correction.
Signed-off-by: Jonathan Kollasch jakllsch@kollasch.net ---
On Thu, Oct 14, 2010 at 03:14:02PM +0000, Jonathan A. Kollasch wrote:
Also, spelling correction.
Changing UK english -> US english is not correcting spelling.
@@ -1844,7 +1853,7 @@
- Keep the second set NULLed if it should be ignored. Keep the subsystem IDs
- NULLed if they don't identify the board fully and if you can't use DMI.
- But please take care to provide an as complete set of pci ids as possible;
- autodetection is the preferred behaviour and we would like to make sure that
- autodetection is the preferred behavior and we would like to make sure that
- matches are unique.
- If PCI IDs are not sufficient for board matching, the match can be further
Luc Verhaegen.
On 14.10.2010 17:14, Jonathan A. Kollasch wrote:
Add board enable for EPoX EP-8NPA7I (and possibly other similar EPoX boards). Also, spelling correction.
I don't understand what's wrong with the spelling. Could you explain?
Signed-off-by: Jonathan Kollasch jakllsch@kollasch.net
The board enable is Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Please wait with the commit until the partial write conversion in flashrom is over to make sure that functionality can be bisected. I expect this to take maybe two more days.
Regards, Carl-Daniel
Hi,
patch (accidentally) committed in r1213. I wanted to cancel the commit, but hit the wrong buttons, sorry.
I omitted the spelling change in the commit, added an entry in print.c so the board appears in "flashrom -L" and wiki output, and I mentioned the southbridge used for the board...
On Thu, Oct 14, 2010 at 05:48:19PM +0200, Carl-Daniel Hailfinger wrote:
On 14.10.2010 17:14, Jonathan A. Kollasch wrote:
Add board enable for EPoX EP-8NPA7I (and possibly other similar EPoX boards).
However, and this is the reason I tried to cancel my commit, your subject says "EP-8NPA7I" while the patch says "EP-8NPAI", which one is correct? Both boards seem to exist, though the "EP-8NPAI" cannot be found on the EPoX website (but I did find PCB photos on the web). There's also a "EP-8NPAJ" on the website.
Which board exactly do you own? Do you have a vendor website URL for it maybe? Also, please post output of:
- flashrom -V -w whatever.bin - lspci -xxxnnnvvv - superiotool -deV
from that board, if possible.
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Please wait with the commit until the partial write conversion in flashrom is over to make sure that functionality can be bisected. I expect this to take maybe two more days.
Ouch, and then I even overlooked this comment, which would be yet another reason to cancel the commit I guess. Sorry.
Uwe.
On Sat, Oct 16, 2010 at 01:08:14AM +0200, Uwe Hermann wrote:
Hi,
patch (accidentally) committed in r1213. I wanted to cancel the commit, but hit the wrong buttons, sorry.
I omitted the spelling change in the commit, added an entry in print.c so the board appears in "flashrom -L" and wiki output, and I mentioned the southbridge used for the board...
On Thu, Oct 14, 2010 at 05:48:19PM +0200, Carl-Daniel Hailfinger wrote:
On 14.10.2010 17:14, Jonathan A. Kollasch wrote:
Add board enable for EPoX EP-8NPA7I (and possibly other similar EPoX boards).
However, and this is the reason I tried to cancel my commit, your subject says "EP-8NPA7I" while the patch says "EP-8NPAI", which one is correct? Both boards seem to exist, though the "EP-8NPAI" cannot be found on the EPoX website (but I did find PCB photos on the web). There's also a "EP-8NPAJ" on the website.
Which board exactly do you own? Do you have a vendor website URL for it maybe? Also, please post output of:
EP-8NPA7I.
- flashrom -V -w whatever.bin
- lspci -xxxnnnvvv
- superiotool -deV
from that board, if possible.
Attached, my superiotool is locally modified for dumping this one.
Jonathan Kollasch
On Sat, Oct 16, 2010 at 01:03:11AM +0000, Jonathan A. Kollasch wrote:
EP-8NPA7I.
OK, thanks.
Attached, my superiotool is locally modified for dumping this one.
What modifications were needed? Should they be merged into superiotool?
# ./flashrom -V -w 8n7i6c25.bin flashrom v0.9.3-r1213 on NetBSD 5.99.39 (i386), built with libpci 3.1.3, GCC 4.1.3 20080704 prerelease (NetBSD nb2 20081120), little endian flashrom is free software, get the source code at http://www.flashrom.org
Calibrating delay loop... OS timer resolution is 2 usecs, 903M loops per second, 10 myus = 12 us, 100 myus = 102 us, 1000 myus = 1017 us, 10000 myus = 10106 us, 8 myus = 10 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: " " DMI string system-product-name: " " DMI string system-version: " " DMI string baseboard-manufacturer: "EPoX COMPUTER CO., LTD" DMI string baseboard-product-name: "nForce4 DDR: 8NPA7I, 8NPA7I/G, 8NPAI, 8NPAI/G Series" DMI string baseboard-version: "1.x" DMI string chassis-type: "Desktop" Found chipset "NVIDIA CK804", enabling flash write... chipset PCI ID is 10de:0050, OK. This chipset supports the following protocols: Non-SPI. Disabling flash write protection for board "EPoX EP-8NPAI"... OK.
[...]
Found chip "PMC Pm49FL004" (512 KB, LPC,FWH) at physical address 0xfff80000.
[...]
=== This flash part has status UNTESTED for operations: WRITE The test status of this chip may have been updated in the latest development version of flashrom. If you are running the latest development version, please email a report to flashrom@flashrom.org if any of the above operations work correctly for you with this flash part. Please include the flashrom output with the additional -V option for all operations you tested (-V, -Vr, -Vw, -VE), and mention which mainboard or programmer you tested. Please mention your board in the subject line. Thanks for your help! Flash image seems to be a legacy BIOS. Disabling checks. Erasing flash chip... Looking at blockwise erase function 0... trying... 0x000000-0x000fff, 0x001000-0x001fff, 0x002000-0x002fff, 0x003000-0x003fff, 0x004000-0x004fff, 0x005000-0x005fff, 0x006000-0x006fff, 0x007000-0x007fff, 0x008000-0x008fff, 0x009000-0x009fff, 0x00a000-0x00afff, 0x00b000-0x00bfff, 0x00c000-0x00cfff, 0x00d000-0x00dfff, 0x00e000-0x00efff, 0x00f000-0x00ffff, 0x010000-0x010fff, 0x011000-0x011fff, 0x012000-0x012fff, 0x013000-0x013fff, 0x014000-0x014fff, 0x015000-0x015fff, 0x016000-0x016fff, 0x017000-0x017fff, 0x018000-0x018fff, 0x019000-0x019fff, 0x01a000-0x01afff, 0x01b000-0x01bfff, 0x01c000-0x01cfff, 0x01d000-0x01dfff, 0x01e000-0x01efff, 0x01f000-0x01ffff, 0x020000-0x020fff, 0x021000-0x021fff, 0x022000-0x022fff, 0x023000-0x023fff, 0x024000-0x024fff, 0x025000-0x025fff, 0x026000-0x026fff, 0x027000-0x027fff, 0x028000-0x028fff, 0x029000-0x029fff, 0x02a000-0x02afff, 0x02b000-0x02bfff, 0x02c000-0x02cfff, 0x02d000-0x02dfff, 0x02e000-0x02efff, 0x02f000-0x02ffff, 0x030000-0x030fff, 0x031000-0x031fff, 0x032000-0x032fff, 0x033000-0x033fff, 0x034000-0x034fff, 0x035000-0x035fff, 0x036000-0x036fff, 0x037000-0x037fff, 0x038000-0x038fff, 0x039000-0x039fff, 0x03a000-0x03afff, 0x03b000-0x03bfff, 0x03c000-0x03cfff, 0x03d000-0x03dfff, 0x03e000-0x03efff, 0x03f000-0x03ffff, 0x040000-0x040fff, 0x041000-0x041fff, 0x042000-0x042fff, 0x043000-0x043fff, 0x044000-0x044fff, 0x045000-0x045fff, 0x046000-0x046fff, 0x047000-0x047fff, 0x048000-0x048fff, 0x049000-0x049fff, 0x04a000-0x04afff, 0x04b000-0x04bfff, 0x04c000-0x04cfff, 0x04d000-0x04dfff, 0x04e000-0x04efff, 0x04f000-0x04ffff, 0x050000-0x050fff, 0x051000-0x051fff, 0x052000-0x052fff, 0x053000-0x053fff, 0x054000-0x054fff, 0x055000-0x055fff, 0x056000-0x056fff, 0x057000-0x057fff, 0x058000-0x058fff, 0x059000-0x059fff, 0x05a000-0x05afff, 0x05b000-0x05bfff, 0x05c000-0x05cfff, 0x05d000-0x05dfff, 0x05e000-0x05efff, 0x05f000-0x05ffff, 0x060000-0x060fff, 0x061000-0x061fff, 0x062000-0x062fff, 0x063000-0x063fff, 0x064000-0x064fff, 0x065000-0x065fff, 0x066000-0x066fff, 0x067000-0x067ff f, 0x068000-0x068fff, 0x069000-0x069fff, 0x06a000-0x06afff, 0x06b000-0x06bfff, 0x06c000-0x06cfff, 0x06d000-0x06dfff, 0x06e000-0x06efff, 0x06f000-0x06ffff, 0x070000-0x070fff, 0x071000-0x071fff, 0x072000-0x072fff, 0x073000-0x073fff, 0x074000-0x074fff, 0x075000-0x075fff, 0x076000-0x076fff, 0x077000-0x077fff, 0x078000-0x078fff, 0x079000-0x079fff, 0x07a000-0x07afff, 0x07b000-0x07bfff, 0x07c000-0x07cfff, 0x07d000-0x07dfff, 0x07e000-0x07efff, 0x07f000-0x07ffff, SUCCESS. Writing flash chip... writing sector at 0xfbf7e000 failed! FAILED!
This looks like it actually didn't work. Did it work before? Maybe it's related to the recent changes in trunk?
Uwe.
On Sat, Oct 16, 2010 at 11:04:06AM +0200, Uwe Hermann wrote:
On Sat, Oct 16, 2010 at 01:03:11AM +0000, Jonathan A. Kollasch wrote:
Writing flash chip... writing sector at 0xfbf7e000 failed! FAILED!
This looks like it actually didn't work. Did it work before? Maybe it's related to the recent changes in trunk?
I don't think so. I suspect it's a sector-read-lock problem. These sectors return 0xff, it actually screwed up the initial backup image I made, before discovering the write lock. However, once running under coreboot (w/ a different flash chip) the chip verifies correctly.
Jonathan Kollasch
On Sat, Oct 16, 2010 at 02:24:21PM +0000, Jonathan A. Kollasch wrote:
On Sat, Oct 16, 2010 at 11:04:06AM +0200, Uwe Hermann wrote:
On Sat, Oct 16, 2010 at 01:03:11AM +0000, Jonathan A. Kollasch wrote:
Writing flash chip... writing sector at 0xfbf7e000 failed! FAILED!
This looks like it actually didn't work. Did it work before? Maybe it's related to the recent changes in trunk?
I don't think so. I suspect it's a sector-read-lock problem. These sectors return 0xff, it actually screwed up the initial backup image I made, before discovering the write lock. However, once running under coreboot (w/ a different flash chip) the chip verifies correctly.
Further analysis of the f-segment board enable shows that we need to be unsetting the bits in 0:1.0 92.b. No wonder it only works under coreboot.
A patch is planned.
Jonathan Kollasch
On Sat, Oct 16, 2010 at 01:03:11AM +0000, Jonathan A. Kollasch wrote:
Which board exactly do you own? Do you have a vendor website URL for it maybe? Also, please post output of:
EP-8NPA7I.
Thanks, fixed the name in r1214 and added the board URL.
Uwe.
-
Carl-Daniel Hailfinger -
Jonathan A. Kollasch -
Luc Verhaegen -
Uwe Hermann