Re: [flashrom] [PATCH 1/3] Print all compile commands to the build details file as well.

[Carl-Daniel Hailfinger]

On 18.01.2016 00:28, Stefan Tauner wrote:
> Signed-off-by: Stefan Tauner

I'm not totally happy about not logging the commands during actual
compilation. That way, if something fails after the configure phase, we
need both a paste from the shell and the debug log file.
Anyway...

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH 1/3] Print all compile commands to the build details file as well.

[Stefan Tauner]

On Sun, 24 Jan 2016 22:56:46 +0100
Carl-Daniel Hailfinger  wrote:
> On 18.01.2016 00:28, Stefan Tauner wrote:
> > Signed-off-by: Stefan Tauner
>
> I'm not totally happy about not logging the commands during actual
> compilation. That way, if something fails after the configure phase, we
> need both a paste from the shell and the debug log file.

Well, up to my previous patch we would had to tell the user to edit the
makefile (probably multiple times) to get the necessary information at
all - which I think I have never done because most of the time our
makefile works very well and the libraries we use are widely available
(even more so now since we support libftdi 0 and 1... only libusb1 will
become a problem for really old systems).

So I don't really think it is needed. However, if we reach a consensus
on that we can add it later easily.
> Anyway...
>
> Acked-by: Carl-Daniel Hailfinger

Thanks, r1919.