Re: [flashrom] [PATCH 2/3] serprog: small improvements

[Uwe Hermann]

On Thu, Sep 08, 2011 at 12:56:22AM +0200, Stefan Tauner wrote:
> @@ -220,32 +220,27 @@ static int sp_check_commandavail(uint8_t command)
>  static int sp_automatic_cmdcheck(uint8_t cmd)
>  {
>    if ((sp_check_avail_automatic) && (sp_check_commandavail(cmd) == 0)) {
> msg_pdbg("Warning: Automatic command availability check"
> 		" failed for cmd %d - wont execute cmd\n",cmd);
> msg_pdbg("Warning: Automatic command availability check failed "
> 	 "for cmd 0x%x - wont execute cmd\n", cmd);

won't
> msg_pdbg(MSGHEADER "Bus support: parallel=%s, LPC=%s, FWH=%s, SPI=%s\n",
>  (c & CHIP_BUSTYPE_PARALLEL) ? "on" : "off",
>  (c & CHIP_BUSTYPE_LPC) ? "on" : "off",
>  (c & CHIP_BUSTYPE_FWH) ? "on" : "off",
>  (c & CHIP_BUSTYPE_SPI) ? "on" : "off");

Hm, I was thinking multiple times now that maybe we should change
PARALLEL to PAR in all the code, it makes places like this where
LPC/FWH/SPI cases are handles align pretty nicely (same length).
That's for another patch, though.

Acked-by: Uwe Hermann

Uwe.

[PATCH 2/3] serprog: small improvements

[Stefan Tauner]

On Thu, 15 Sep 2011 22:03:01 +0200
Uwe Hermann  wrote:
> On Thu, Sep 08, 2011 at 12:56:22AM +0200, Stefan Tauner wrote:
> > msg_pdbg(MSGHEADER "Bus support: parallel=%s, LPC=%s, FWH=%s, SPI=%s\n",
> >  (c & CHIP_BUSTYPE_PARALLEL) ? "on" : "off",
> >  (c & CHIP_BUSTYPE_LPC) ? "on" : "off",
> >  (c & CHIP_BUSTYPE_FWH) ? "on" : "off",
> >  (c & CHIP_BUSTYPE_SPI) ? "on" : "off");
>
> Hm, I was thinking multiple times now that maybe we should change
> PARALLEL to PAR in all the code, it makes places like this where
> LPC/FWH/SPI cases are handles align pretty nicely (same length).
> That's for another patch, though.

well, yes. would be even nicer now that carldani cut those macros down
to 7 characters.
> Acked-by: Uwe Hermann

thanks! i have committed it now in r1456. first i thought i would just
quickly convince you regarding the kHz vs. Hz discussion... but since
that has not worked out and i was too lazy yet to rewrite it to Hz
resolution, i thought it is better to get this in now.