Re: [flashrom] Added chipsets

[Stefan Tauner]

Hello Николай,

that's quite some work you have done, thank you.
There is one very important bit missing though: the signed-off-by line
that certifies that you are legally allowed to release these changes
under a free license.
Please see http://flashrom.org/Development_Guidelines and
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure for
details. We can not commit your changes without this.

It would also make sense to split your huge patch into smaller pieces
(e.g. one patch per manufacturer) so that we can review it easier.
I have not looked at the patch in detail, but some naming will have to
change probably.
> +#define SPANSION_S25FL128       0x2018
> +#define SPANSION_S25FL256       0x0219
> +#define SPANSION_S25FL512       0x0220

these look like typos?

Added chipsets

[Николай Николаев]

Hi Stefan,
> these look like typos?

This is not typos. I'm verified again all documentation.
The chip S25FL128S has a Device Identification like a 2018 (table 11.2 page
133)
The chip S25FL256S has a Device Identification like a 0219 (table 11.2 page
133)
The chip S25FL256S has a Device Identification like a 0220 (table 11.4 page
123)
> > +#define SPANSION_S25FL128       0x2018
> > +#define SPANSION_S25FL256       0x0219
> > +#define SPANSION_S25FL512       0x0220
> It would also make sense to split your huge patch into smaller pieces

I will keep in mind for next patches.

Added chipsets

[Peter Lemenkov]

Hello!

2013/2/22 Stefan Tauner :
> It would also make sense to split your huge patch into smaller pieces
> (e.g. one patch per manufacturer) so that we can review it easier.

Maybe it's time to consider switching to Git entirely? Git is much
more better suited for this kind of task.