CID1130010: Resource leak
The system resource will not be reclaimed and reused, reducing the future availability of the resource. In verify_range: Leak of memory or pointers to system resources
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org
Index: flashrom.c =================================================================== --- flashrom.c (revision 1763) +++ flashrom.c (working copy) @@ -676,7 +676,8 @@
if (!flash->chip->read) { msg_cerr("ERROR: flashrom has no read function for this flash chip.\n"); - return 1; + ret = -1; + goto out_free; } if (!readbuf) { msg_gerr("Could not allocate memory!\n");
On Tue, 19 Nov 2013 20:35:57 +0100 Stefan Reinauer stefan.reinauer@coreboot.org wrote:
CID1130010: Resource leak
The system resource will not be reclaimed and reused, reducing the future availability of the resource. In verify_range: Leak of memory or pointers to system resources
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org
Alternative solution attached.
On Fri, 9 May 2014 00:22:52 +0200 Stefan Tauner stefan.tauner@alumni.tuwien.ac.at wrote:
Alternative solution attached.
Acked-by: Stefan Tauner stefan.tauner@alumni.tuwien.ac.at and committed in r1800.