here's the completely fixed patch.

[Brandon Dowdy]

Here is the same patch that is completely looked at and fixed.

[Stefan Reinauer]

* Brandon Dowdy  [110427 23:27]:
> Here is the same patch that is completely looked at and fixed.

This patch does not hook up any of the code it adds. It basically does
nothing. Did you ever try this code before sending it? I'm pretty sure
it doesn't work, whatever the problem is it's trying to solve.

Some other things:

- why do you call the EC access function UC? 
 - Maybe these functions can be shared with some KBC stuff and/or moved
   to a separate file?
 - Signed-off-by: is missing

Stefan

[Michael Karcher]

Am Donnerstag, den 28.04.2011, 00:36 +0200 schrieb Stefan Reinauer:
> why do you call the EC access function UC?

This is actually my idea, i called them "uc" for microcontroller,
because that interface is used for embedded controllers as well as
keyboard controllers.
> Signed-off-by: is missing

He had it in the original patch, but was told that as most code in that
patch was not written by him, he can not sign off that. Please see the
end of
http://www.coreboot.org/pipermail/flashrom/2011-April/006252.html

Regards,
  Michael Karcher