Patch for "LE25FW406A"

[The Raven]

Here is a Patch (r1791) for adding "LE25FW406A".

Tested:
Probe -> Probing for Sanyo LE25FW406A, 512 kB: probe_spi_res2: id1 0x62,
id2 0x1a
Read -> ok
Erase -> ok
Write -> 512kb random data ok
Verify -> ok

It also adds "/* Sanyo */" description to the Sanyo-Chips. This is only
a cosmetic thing.

[Stefan Tauner]

On Wed, 14 May 2014 17:02:48 +0200
The Raven  wrote:
> Here is a Patch (r1791) for adding "LE25FW406A".
>
> Tested:
> Probe -> Probing for Sanyo LE25FW406A, 512 kB: probe_spi_res2: id1 0x62,
> id2 0x1a
> Read -> ok
> Erase -> ok
> Write -> 512kb random data ok
> Verify -> ok
>
> It also adds "/* Sanyo */" description to the Sanyo-Chips. This is only
> a cosmetic thing.

Hi and thanks for your patch!

You will have to sign off the patch with your real name too.
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
Since I doubt that this patch reaches the threshold of originality
needed to become "your" work (at least in somewhat sane jurisdictions),
I can also sign it off myself if you prefer that, but IMHO you should
stand by your work. :)

Since we do not have a datasheet for this chip, it would be good if you
could test all erase functions dedicatedly by commenting out all but
one eraser block in flashchips.c (Since flashrom tries the top most
first, you can leave out testing it), e.g.:
//				.eraseblocks = { {4 * 1024, 128} },
//				.block_erase = spi_block_erase_d7,
//			},	{

When you are at it anyway, please capture one verbose log. I'd like to
see if we can spot anything interesting. Where did you find the chip
BTW?

[The Raven]

Hi Again,
> Hi and thanks for your patch!
>
> You will have to sign off the patch with your real name too.
> http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
> Since I doubt that this patch reaches the threshold of originality
> needed to become "your" work (at least in somewhat sane jurisdictions),
> I can also sign it off myself if you prefer that, but IMHO you should
> stand by your work. :)

Please add the patch. It's tested and seems to work with
the "LE25FW406A". I can do more testing and logs if you like.
> Since we do not have a datasheet for this chip, it would be good if you
> could test all erase functions dedicatedly by commenting out all but
> one eraser block in flashchips.c (Since flashrom tries the top most
> first, you can leave out testing it), e.g.:
> //				.eraseblocks = { {4 * 1024, 128} },
> //				.block_erase = spi_block_erase_d7,
> //			},	{

Agree with you, unfortunately we have no Datasheet.
I have tested all erase functions. Before erasing i have filled the chip
always with random data from "dd".
It seems that all erase functions work as they should. :-)
And writing and reading too.
> When you are at it anyway, please capture one verbose log. I'd like to
> see if we can spot anything interesting. Where did you find the chip
> BTW?

Is this log ok or do you need more verbosity?
Unfortunately i don't remember from which device this chip was. I think
it was a
harddisk, but i am not really sure sorry. :-(

THX and Greetings

[Stefan Tauner]

On Fri, 16 May 2014 18:11:50 +0200
The Raven  wrote:
> > You will have to sign off the patch with your real name too.
> > http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
> > Since I doubt that this patch reaches the threshold of originality
> > needed to become "your" work (at least in somewhat sane jurisdictions),
> > I can also sign it off myself if you prefer that, but IMHO you should
> > stand by your work. :)
>
> Please add the patch. It's tested and seems to work with
> the "LE25FW406A". I can do more testing and logs if you like.
> > Since we do not have a datasheet for this chip, it would be good if you
> > could test all erase functions dedicatedly by commenting out all but
> > one eraser block in flashchips.c (Since flashrom tries the top most
> > first, you can leave out testing it), e.g.:
> > //				.eraseblocks = { {4 * 1024, 128} },
> > //				.block_erase = spi_block_erase_d7,
> > //			},	{
>
> Agree with you, unfortunately we have no Datasheet.
> I have tested all erase functions. Before erasing i have filled the chip
> always with random data from "dd".
> It seems that all erase functions work as they should. :-)
> And writing and reading too.

Thank you.

After private discussion (with the author) I have decided to sign off
the patch myself. I have committed it in r1796 after minor refinements.