[PATCH] Add Winbond W49F020 (Xbox) support

[Carl-Daniel Hailfinger]

Hi Alec,

could you try this patch on your Xbox? If it works, please reply-to-all
with the output from
flashrom -V
and include a line saying "Acked-by: Your Name ".

Add Winbond W49F020 support. This chip is used on some Xbox versions.

Signed-off-by: Carl-Daniel Hailfinger

Index: flashrom-w49f020/flashchips.c
===================================================================
--- flashrom-w49f020/flashchips.c	(Revision 1082)
+++ flashrom-w49f020/flashchips.c	(Arbeitskopie)
@@ -6474,6 +6474,29 @@

{
    	.vendor		= "Winbond",
+		.name		= "W49F020",
+		.bustype	= CHIP_BUSTYPE_PARALLEL,
+		.manufacture_id	= WINBOND_ID,
+		.model_id	= W_49F020,
+		.total_size	= 256,
+		.page_size	= 128,
+		.feature_bits	= FEATURE_EITHER_RESET,
+		.tested		= TEST_UNTESTED,
+		.probe		= probe_jedec,
+		.probe_timing	= 10,
+		.block_erasers	=
+		{
+			{
+				.eraseblocks = { {256 * 1024, 1} },
+				.block_erase = erase_chip_block_jedec,
+			}
+		},
+		.write		= write_jedec_1,
+		.read		= read_memmapped,
+	},
+
+	{
+		.vendor		= "Winbond",
    	.name		= "W49V002A",
    	.bustype	= CHIP_BUSTYPE_LPC,
    	.manufacture_id	= WINBOND_ID,

[Carl-Daniel Hailfinger]

On 16.07.2010 12:55, Carl-Daniel Hailfinger wrote:
> Hi Alec,
>
> could you try this patch on your Xbox? If it works, please reply-to-all
> with the output from
> flashrom -V
> and include a line saying "Acked-by: Your Name ".
>
> Add Winbond W49F020 support. This chip is used on some Xbox versions.
>
> Signed-off-by: Carl-Daniel Hailfinger

This patch can also be downloaded at
http://patchwork.coreboot.org/patch/1636/raw/

Please don't test write/erase unless you can recover.

Regards,
Carl-Daniel

[Alec Wright]

On Fri, 2010-07-16 at 12:55 +0200, Carl-Daniel Hailfinger wrote:
> Hi Alec,
>
> could you try this patch on your Xbox? If it works, please reply-to-all
> with the output from
> flashrom -V
> and include a line saying "Acked-by: Your Name ".
>
> Add Winbond W49F020 support. This chip is used on some Xbox versions.
>
> Signed-off-by: Carl-Daniel Hailfinger
> Index: flashrom-w49f020/flashchips.c
>
> --- flashrom-w49f020/flashchips.c	(Revision 1082)
> +++ flashrom-w49f020/flashchips.c	(Arbeitskopie)
> @@ -6474,6 +6474,29 @@
>
> {
>    	.vendor		= "Winbond",
> .name		= "W49F020",
> .bustype	= CHIP_BUSTYPE_PARALLEL,
> .manufacture_id	= WINBOND_ID,
> .model_id	= W_49F020,
> .total_size	= 256,
> .page_size	= 128,
> .feature_bits	= FEATURE_EITHER_RESET,
> .tested		= TEST_UNTESTED,
> .probe		= probe_jedec,
> .probe_timing	= 10,
> .block_erasers	=
> {
> 	{
> 		.eraseblocks = { {256 * 1024, 1} },
> 		.block_erase = erase_chip_block_jedec,
> 	}
> },
> .write		= write_jedec_1,
> .read		= read_memmapped,
> },
> {
> .vendor		= "Winbond",
> .name		= "W49V002A",
> .bustype	= CHIP_BUSTYPE_LPC,
> .manufacture_id	= WINBOND_ID,

I had some interesting results. It didnt compile as-is, since the svn
version still has the board_enable.c:788 error, but when i applied the
patch to your modified version, it compiled fine and detected the chip:
flashrom output: http://pastebin.ca/1901707
flashrom -V output: http://pastebin.ca/1901709
But when I try flashrom -r test.bin, it says this:
http://pastebin.ca/1901714 then it suddenly dies, or at least
disconnects from the network, since my SSH session freezes. I could try
plugging it into a TV to test it and see what the error is, if that'd
help?

And apparently I'm supposed to say this:
Acked-by: Alec Wright

[Carl-Daniel Hailfinger]

On 16.07.2010 14:06, Alec Wright wrote:
> On Fri, 2010-07-16 at 12:55 +0200, Carl-Daniel Hailfinger wrote:
> > Add Winbond W49F020 support. This chip is used on some Xbox versions.
> >
> > Signed-off-by: Carl-Daniel Hailfinger
>
> I had some interesting results. It didnt compile as-is, since the svn
> version still has the board_enable.c:788 error, but when i applied the
> patch to your modified version, it compiled fine and detected the chip:
> flashrom output: http://pastebin.ca/1901707
> flashrom -V output: http://pastebin.ca/1901709
> But when I try flashrom -r test.bin, it says this:
> http://pastebin.ca/1901714 then it suddenly dies, or at least
> disconnects from the network, since my SSH session freezes. I could try
> plugging it into a TV to test it and see what the error is, if that'd
> help?
>
> And apparently I'm supposed to say this:
> Acked-by: Alec Wright

Thanks, marked as supported for probing and committed in r1086.

Remaining issues on your box:
- Find out why reading hangs
- Support pciutils older than version 2.2.

Regards,
Carl-Daniel