Re: [flashrom] [PATCH] Unify non-shifted and shifted JEDEC access.

[Stefan Tauner]

On Thu,  7 Aug 2014 23:49:57 +0200
Stefan Tauner  wrote:
> Some Parallel bus chips have a 16-bit mode and an 8-bit mode. They use
> normal JEDEC addresses for 16-bit mode and shifted addresses (by 1 bit)
> for 8-bit mode. Some programmers can access them in 16-bit mode, but on
> all flashrom-supported programmers so far, we access them in 8-bit mode.
> This means we have to shift the addresses but apart from the addresses
> we can share the code.
>
> This patch makes this possible by checking the chip's FEATURE_ADDR_SHIFTED
> flag in common JEDEC functions and applying the right addresses respectively.
>
> Signed-off-by: Carl-Daniel Hailfinger 
> Signed-off-by: Stefan Tauner
>
> I have removed the obsolete code, changed the probe_timing field to 10
> plus a comment explaining it where relevant, applied the changes to a
> few other chips that probably were not there before, and refined the
> shift handling as discussed on IRC.

Acked by Carl-Daniel and committed in r1840.