[Patch] Shuttle AK31

[Luc Verhaegen]

Resending this patch to the newly formed flashrom ml. Ron already 
kindly acked this patch.

Mateusz, the owner of this board gave me a brief comment on irc stating 
that it didn't work. Which is also the last i heard from him.

Mateusz, get back to us and get us at least the flashrom output.

Luc Verhaegen.

[Luc Verhaegen]

On Mon, Jul 06, 2009 at 07:26:40PM +0200, Luc Verhaegen wrote:
> Resending this patch to the newly formed flashrom ml. Ron already 
> kindly acked this patch.
>
> Mateusz, the owner of this board gave me a brief comment on irc stating 
> that it didn't work. Which is also the last i heard from him.
>
> Mateusz, get back to us and get us at least the flashrom output.
>
> Luc Verhaegen.

Mateusz,

Now there is also an ack from stepan.

Please test.

http://patchwork.coreboot.org/patch/8/

Luc Verhaegen.

[Mateusz Murawski]

-------- Original Message  --------
Subject: Re: [flashrom] [Patch] Shuttle AK31
From: Luc Verhaegen 
To: [e-mail]
Cc: Mateusz Murawski 
Date: 2009-09-09 22:23
> On Mon, Jul 06, 2009 at 07:26:40PM +0200, Luc Verhaegen wrote:
> > Resending this patch to the newly formed flashrom ml. Ron already
> > kindly acked this patch.
> >
> > Mateusz, the owner of this board gave me a brief comment on irc stating
> > that it didn't work. Which is also the last i heard from him.
> >
> > Mateusz, get back to us and get us at least the flashrom output.
> >
> > Luc Verhaegen.
>
> Mateusz,
>
> Now there is also an ack from stepan.
>
> Please test.
>
> http://patchwork.coreboot.org/patch/8/

Tested. Reading working, writing not
Acked-by: Mateusz Murawski

[Carl-Daniel Hailfinger]

r790.

Regards,
Carl-Daniel

[Carl-Daniel Hailfinger]

Hi Mateusz,

are there any updates on this patch? It is the oldest unmerged patch and
I'd like to close the issue.

On 06.07.2009 19:26, Luc Verhaegen wrote:
> Resending this patch to the newly formed flashrom ml. Ron already 
> kindly acked this patch.
>
> Mateusz, the owner of this board gave me a brief comment on irc stating 
> that it didn't work. Which is also the last i heard from him.
>
> Mateusz, get back to us and get us at least the flashrom output.

Regards,
Carl-Daniel

[Carl-Daniel Hailfinger]

Updated patch because the board enable table changed too much. No code
changes, so I'm reusing the original commit message and acks.

Board enable for Shuttle AK31.

All AK31 versions, 1.x, 2.x and 3.x are supported by this board enable.
Sadly this board can not be autodetected.

Re-uses the epox ep 8k5a2 board enable, which now lost its check for
the VT8235 ISA bridge and got renamed to w836xx_memw_enable_2e.

Signed-off-by: Luc Verhaegen 
Acked-by: Ronald G. Minnich 
Acked-by: Stefan Reinauer

Index: flashrom-shuttle_ak31/board_enable.c
===================================================================
--- flashrom-shuttle_ak31/board_enable.c	(Revision 753)
+++ flashrom-shuttle_ak31/board_enable.c	(Arbeitskopie)
@@ -297,18 +297,13 @@
 }

/**
- * Suited for EPoX EP-8K5A2 and Albatron PM266A Pro.
+ * Suited for:
+ *   - EPoX EP-8K5A2: VIA KT333 + VT8235.
+ *   - Albatron PM266A Pro: VIA P4M266A + VT8235.
+ *   - Shuttle AK31 (all versions): VIA KT266 + VT8233.
  */
-static int board_epox_ep_8k5a2(const char *name)
+static int w836xx_memw_enable_2e(const char *name)
 {
-	struct pci_dev *dev;
-
-	dev = pci_dev_find(0x1106, 0x3177);	/* VT8235 ISA bridge */
-	if (!dev) {
-		fprintf(stderr, "\nERROR: VT8235 ISA bridge not found.\n");
-		return -1;
-	}
-
    w836xx_memw_enable(0x2E);

return 0;
@@ -1066,7 +1061,7 @@
    {0x8086, 0x2926, 0x147b, 0x1084,  0x11ab, 0x4364, 0x147b, 0x1084, NULL,         NULL,          "Abit",        "IP35",               board_abit_ip35},
    {0x8086, 0x1130,      0,      0,  0x105a, 0x0d30, 0x105a, 0x4d33, "acorp",      "6a815epd",    "Acorp",       "6A815EPD",           board_acorp_6a815epd},
    {0x1022, 0x746B, 0x1022, 0x36C0,       0,      0,      0,      0, "AGAMI",      "ARUMA",       "agami",       "Aruma",              w83627hf_gpio24_raise_2e},
-	{0x1106, 0x3177, 0x17F2, 0x3177,  0x1106, 0x3148, 0x17F2, 0x3148, NULL,         NULL,          "Albatron",    "PM266A*",            board_epox_ep_8k5a2},
+	{0x1106, 0x3177, 0x17F2, 0x3177,  0x1106, 0x3148, 0x17F2, 0x3148, NULL,         NULL,          "Albatron",    "PM266A*",            w836xx_memw_enable_2e},
    {0x1106, 0x3205, 0x1106, 0x3205,  0x10EC, 0x8139, 0xA0A0, 0x0477, NULL,         NULL,          "AOpen",       "vKM400Am-S",         board_aopen_vkm400},
    {0x1022, 0x2090,      0,      0,  0x1022, 0x2080,      0,      0, "artecgroup", "dbe61",       "Artec Group", "DBE61",              board_artecgroup_dbe6x},
    {0x1022, 0x2090,      0,      0,  0x1022, 0x2080,      0,      0, "artecgroup", "dbe62",       "Artec Group", "DBE62",              board_artecgroup_dbe6x},
@@ -1080,7 +1075,7 @@
    {0x1106, 0x3149, 0x1565, 0x3206,  0x1106, 0x3344, 0x1565, 0x1202, NULL,         NULL,          "Biostar",     "P4M80-M4",           it8705_rom_write_enable},
    {0x8086, 0x3590, 0x1028, 0x016c,  0x1000, 0x0030, 0x1028, 0x016c, NULL,         NULL,          "Dell",        "PowerEdge 1850",     ich5_gpio23_raise},
    {0x1106, 0x3038, 0x1019, 0x0996,  0x1106, 0x3177, 0x1019, 0x0996, NULL,         NULL,          "Elitegroup",  "K7VTA3",             it8705f_write_enable_2e},
-	{0x1106, 0x3177, 0x1106, 0x3177,  0x1106, 0x3059, 0x1695, 0x3005, NULL,         NULL,          "EPoX",        "EP-8K5A2",           board_epox_ep_8k5a2},
+	{0x1106, 0x3177, 0x1106, 0x3177,  0x1106, 0x3059, 0x1695, 0x3005, NULL,         NULL,          "EPoX",        "EP-8K5A2",           w836xx_memw_enable_2e},
    {0x10EC, 0x8139, 0x1695, 0x9001,  0x11C1, 0x5811, 0x1695, 0x9015, NULL,         NULL,          "EPoX",        "EP-8RDA3+",          board_epox_ep_8rda3plus},
    {0x8086, 0x7110,      0,      0,  0x8086, 0x7190,      0,      0, "epox",       "ep-bx3",      "EPoX",        "EP-BX3",             board_epox_ep_bx3},
    {0x1039, 0x0761,      0,      0,       0,      0,      0,      0, "gigabyte",   "2761gxdk",    "GIGABYTE",    "GA-2761GXDK",        it87xx_probe_spi_flash},
@@ -1105,6 +1100,7 @@
    {0x1106, 0x0571, 0x1462, 0x7120,       0,      0,      0,      0, "msi",        "kt4v",        "MSI",         "MS-6712 (KT4V)",     board_msi_kt4v},
    {0x8086, 0x2658, 0x1462, 0x7046,  0x1106, 0x3044, 0x1462, 0x046d, NULL,         NULL,          "MSI",         "MS-7046",            ich6_gpio19_raise},
    {0x10de, 0x005e,      0,      0,       0,      0,      0,      0, "msi",        "k8n-neo3",    "MSI",         "MS-7135 (K8N Neo3)", w83627thf_gpio4_4_raise_4e},
+	{0x1106, 0x3099,      0,      0,  0x1106, 0x3074,      0,      0, "shuttle",    "ak31",        "Shuttle",     "AK31",               w836xx_memw_enable_2e},
    {0x1106, 0x3104, 0x1297, 0xa238,  0x1106, 0x3059, 0x1297, 0xc063, NULL,         NULL,          "Shuttle",     "AK38N",              it8705f_write_enable_2e},
    {0x10DE, 0x0050, 0x1297, 0x5036,  0x1412, 0x1724, 0x1297, 0x5036, NULL,         NULL,          "Shuttle",     "FN25",               board_shuttle_fn25},
    {0x1106, 0x3038, 0x0925, 0x1234,  0x1106, 0x3058, 0x15DD, 0x7609, NULL,         NULL,          "Soyo",        "SY-7VCA",            board_soyo_sy_7vca},

[Carl-Daniel Hailfinger]

Mateusz tested this and probe of his chip worked fine. Erase didn't
work, but that's probably due to some block locking or a broken erase
function. Not sure yet.
I asked Mateusz to ack this patch as well, but in the meantime you have
my ack.
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel