On Fri, 26 Jul 2013 12:47:39 -0700 David Hendricks dhendrix@google.com wrote:
Hmmm, that return statement seems to be getting rather unwieldy especially since we can probably expect a lot more variants. Maybe you can take this opportunity to re-factor the code a bit, make a table of known strings, and use a loop instead? You could also annotate the table entries to indicate whether the processor is known-working and print a warning if not.
Alternately, perhaps it would be sufficient to use strstr() to find "GodsonV2", "Loongson-2", and "Loongson-3"?
Yes it's awful... but I want to know if it works first and even then I think I don't care enough ATM. I had enough string handling in C this week already :)