ISSI Flash parts request to be added

[Johnny Chien]

Hi FlashROM,

We have a customer who pointed us to your organization. They asked if we could get more of our SPI NOR flash supported. Do you have a contact or person who would be able to guide us in this activity?

We see the following parts supported here:

[cid:image001.png@01D98CDE.B6E9BC20]

Johnny Chien
Integrated Silicon Solution, Inc.
Phone: [phone]
Mobile: [phone]
Fax: [phone]
Email: [e-mail]

Follow us on Twitter

[Peter Marheine]

The tips at
https://www.flashrom.org/Development_Guidelines#Adding/reviewing_a_new_flash...
will probably help you get started; if the chips you want to add support
for are similar to already-supported chips it should be easy to add the new
ones, but as long as they don't have any very unusual behavior there
shouldn't be anything difficult about it.

On Tue, May 23, 2023 at 11:53 AM Johnny Chien  wrote:
> Hi FlashROM,
>
> We have a customer who pointed us to your organization. They asked if we
> could get more of our SPI NOR flash supported. Do you have a contact or
> person who would be able to guide us in this activity?
>
> We see the following parts supported here:
>
> Johnny Chien
>
> Integrated Silicon Solution, Inc.
>
> Phone: *408.969.4647 <(408)%20969-4647>*
>
> Mobile: *408.786.8210 <(408)%20786-8210>*
>
> Fax: *408.969.4747 <(408)%20969-4747>*
>
> Email: [e-mail]
>
> Follow us on *Twitter*
>
> flashrom mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Anastasia Klimchuk]

Hi Johnny,

Nice to meet you! Yes it would be great to collaborate with you so
that you could add more ISSI SPI flash.

You will need to send a patch to add entries into flashchip.c file.
You can have a look at the file here
https://github.com/flashrom/flashrom/blob/master/flashchips.c
Note that we use github only as a mirror (don't use pull requests).

To send a patch you need to follow the guidelines here
https://www.flashrom.org/Development_Guidelines#Patch_submission

In addition, read specifically the section about adding a new chip
https://www.flashrom.org/Development_Guidelines#Adding/reviewing_a_new_flash...

One more document is about building flashrom from source
https://doc.flashrom.org/dev_guide/building_from_source.html

Will you be able to follow the guidelines and tell us how it goes? You
are welcome to reply to this thread with questions. Please click Reply
all, so that the thread goes on the mailing list: we have a community
of developers. I am also on the thread and happy to help you.

Also as a note: we are currently in progress of updating/reviewing the
documentation, and specifically the dev guidelines will be modernised
soon.
You can definitely start with the current version of guidelines.

Thank you!
--
Anastasia.

[Anastasia Klimchuk]

Also there is an example of a patch which adds support for ISSI chip:
https://review.coreboot.org/c/flashrom/+/68295 you can have a look.

On Mon, May 29, 2023 at 9:54 PM Anastasia Klimchuk  wrote:
> Hi Johnny,
>
> Nice to meet you! Yes it would be great to collaborate with you so
> that you could add more ISSI SPI flash.
>
> You will need to send a patch to add entries into flashchip.c file.
> You can have a look at the file here
> https://github.com/flashrom/flashrom/blob/master/flashchips.c
> Note that we use github only as a mirror (don't use pull requests).
>
> To send a patch you need to follow the guidelines here
> https://www.flashrom.org/Development_Guidelines#Patch_submission
>
> In addition, read specifically the section about adding a new chip
> https://www.flashrom.org/Development_Guidelines#Adding/reviewing_a_new_flash...
>
> One more document is about building flashrom from source
> https://doc.flashrom.org/dev_guide/building_from_source.html
>
> Will you be able to follow the guidelines and tell us how it goes? You
> are welcome to reply to this thread with questions. Please click Reply
> all, so that the thread goes on the mailing list: we have a community
> of developers. I am also on the thread and happy to help you.
>
> Also as a note: we are currently in progress of updating/reviewing the
> documentation, and specifically the dev guidelines will be modernised
> soon.
> You can definitely start with the current version of guidelines.
> Thank you!
>
> Anastasia.