Hello!
I have a device with a XMC25QH6A chip I'm trying to get a full image of. I came across this GitHub issue[1] and associated pull requests here[2] and here[3], but both pull requests were closed with a comment linking to a Gerrit patchset[4] that seems to no longer exist (or I do not have sufficient permissions to view).
I commented on the original issue to ask the rationale behind closing the PRs and to perhaps seek some clarification on what the Gerrit patchset was about last year, but did not receive a response. I was under the impression that perhaps GitHub is not as closely monitored and I'd have better luck emailing the mailing list.
If anyone would please comment on the status of this particular chip and what is blocking Flashrom from supporting it that would be greatly appreciated!
- Eric
[1]: https://github.com/flashrom/flashrom/issues/148
[2]: https://github.com/flashrom/flashrom/pull/150
Hello Eric,
It's good that you wrote on the mailing list! Because we use GitHub as a mirror only, and don't look at issues and PRs. At some point we added an auto-responder but maybe that issue was created before it.
I cannot access that Gerrit patch either, yes looks like it was deleted. Maybe it was migrating the code from pull request - but we don't know now, it's gone.
So, we need a new Gerrit patch from the PR you linked https://github.com/flashrom/flashrom/pull/239 Would it be possible for you to do it? or maybe the original author of the PR would agree to create a patch? I am sorry that it happened like this. We never really did development via GitHub, it was always only a mirror.
For creating a patch, here are our guidelines: https://flashrom.org/dev_guide/development_guide.html Also in case it's useful, doc how to add a chip: https://flashrom.org/contrib_howtos/how_to_add_new_chip.html
Hope it helps, tell me how it goes. Thanks!
On Mon, Mar 24, 2025 at 11:27 AM Eric Park via flashrom flashrom@flashrom.org wrote:
Hello!
I have a device with a XMC25QH6A chip I'm trying to get a full image of. I came across this GitHub issue[1] and associated pull requests here[2] and here[3], but both pull requests were closed with a comment linking to a Gerrit patchset[4] that seems to no longer exist (or I do not have sufficient permissions to view).
I commented on the original issue to ask the rationale behind closing the PRs and to perhaps seek some clarification on what the Gerrit patchset was about last year, but did not receive a response. I was under the impression that perhaps GitHub is not as closely monitored and I'd have better luck emailing the mailing list.
If anyone would please comment on the status of this particular chip and what is blocking Flashrom from supporting it that would be greatly appreciated!
- Eric
flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-leave@flashrom.org
Hi, thank you very much for the reply!
I believe the Gerrit patch is now ready for review here: https://review.coreboot.org/c/flashrom/+/86990
I've modified it to apply on top of the refactored flashchips.c/.h files and to use the new preprocessor macros instead of the direct function calls/magic number variables. (At least that's what I'm guessing since the names were capitalized.) Sorry for submitting multiple patch sets; I'm not too familiar with flashrom internals and it took a couple of tries until the build was successful.
Please let me know if there is anything else I can add/fix/change!
- Eric
On 3/24/2025 4:33 AM, Anastasia Klimchuk wrote:
Hello Eric,
It's good that you wrote on the mailing list! Because we use GitHub as a mirror only, and don't look at issues and PRs. At some point we added an auto-responder but maybe that issue was created before it.
I cannot access that Gerrit patch either, yes looks like it was deleted. Maybe it was migrating the code from pull request - but we don't know now, it's gone.
So, we need a new Gerrit patch from the PR you linked https://github.com/flashrom/flashrom/pull/239 Would it be possible for you to do it? or maybe the original author of the PR would agree to create a patch? I am sorry that it happened like this. We never really did development via GitHub, it was always only a mirror.
For creating a patch, here are our guidelines: https://flashrom.org/dev_guide/development_guide.html Also in case it's useful, doc how to add a chip: https://flashrom.org/contrib_howtos/how_to_add_new_chip.html
Hope it helps, tell me how it goes. Thanks!
On Mon, Mar 24, 2025 at 11:27 AM Eric Park via flashrom flashrom@flashrom.org wrote:
Hello!
I have a device with a XMC25QH6A chip I'm trying to get a full image of. I came across this GitHub issue[1] and associated pull requests here[2] and here[3], but both pull requests were closed with a comment linking to a Gerrit patchset[4] that seems to no longer exist (or I do not have sufficient permissions to view).
I commented on the original issue to ask the rationale behind closing the PRs and to perhaps seek some clarification on what the Gerrit patchset was about last year, but did not receive a response. I was under the impression that perhaps GitHub is not as closely monitored and I'd have better luck emailing the mailing list.
If anyone would please comment on the status of this particular chip and what is blocking Flashrom from supporting it that would be greatly appreciated!
- Eric
flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-leave@flashrom.org
Great, thank you for your work! I added comments to the patch.
On Tue, Mar 25, 2025 at 5:57 AM Eric Park me@ericswpark.com wrote:
Hi, thank you very much for the reply!
I believe the Gerrit patch is now ready for review here: https://review.coreboot.org/c/flashrom/+/86990
I've modified it to apply on top of the refactored flashchips.c/.h files and to use the new preprocessor macros instead of the direct function calls/magic number variables. (At least that's what I'm guessing since the names were capitalized.) Sorry for submitting multiple patch sets; I'm not too familiar with flashrom internals and it took a couple of tries until the build was successful.
Please let me know if there is anything else I can add/fix/change!
- Eric
On 3/24/2025 4:33 AM, Anastasia Klimchuk wrote:
Hello Eric,
It's good that you wrote on the mailing list! Because we use GitHub as a mirror only, and don't look at issues and PRs. At some point we added an auto-responder but maybe that issue was created before it.
I cannot access that Gerrit patch either, yes looks like it was deleted. Maybe it was migrating the code from pull request - but we don't know now, it's gone.
So, we need a new Gerrit patch from the PR you linked https://github.com/flashrom/flashrom/pull/239 Would it be possible for you to do it? or maybe the original author of the PR would agree to create a patch? I am sorry that it happened like this. We never really did development via GitHub, it was always only a mirror.
For creating a patch, here are our guidelines: https://flashrom.org/dev_guide/development_guide.html Also in case it's useful, doc how to add a chip: https://flashrom.org/contrib_howtos/how_to_add_new_chip.html
Hope it helps, tell me how it goes. Thanks!
On Mon, Mar 24, 2025 at 11:27 AM Eric Park via flashrom flashrom@flashrom.org wrote:
Hello!
I have a device with a XMC25QH6A chip I'm trying to get a full image of. I came across this GitHub issue[1] and associated pull requests here[2] and here[3], but both pull requests were closed with a comment linking to a Gerrit patchset[4] that seems to no longer exist (or I do not have sufficient permissions to view).
I commented on the original issue to ask the rationale behind closing the PRs and to perhaps seek some clarification on what the Gerrit patchset was about last year, but did not receive a response. I was under the impression that perhaps GitHub is not as closely monitored and I'd have better luck emailing the mailing list.
If anyone would please comment on the status of this particular chip and what is blocking Flashrom from supporting it that would be greatly appreciated!
- Eric
flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-leave@flashrom.org
-
Anastasia Klimchuk -
Eric Park