Re: [flashrom] [PATCH 1/3] Factor out SPI write/read chunking wrappers.

[Carl-Daniel Hailfinger]

Hi Michael,

thanks for your patch!

Am 05.05.2011 03:04 schrieb Michael Karcher:
> diff --git a/dummyflasher.c b/dummyflasher.c
> index d818a84..b6e67db 100644
> --- a/dummyflasher.c
> +++ b/dummyflasher.c
> @@ -507,12 +507,6 @@ int dummy_spi_send_command(unsigned int writecnt, unsigned int readcnt,
>    return 0;
>   }
>
> -int dummy_spi_read(struct flashchip *flash, uint8_t *buf, int start, int len)
> -{
> /* Maximum read length is unlimited, use 64kB. */
> return spi_read_chunked(flash, buf, start, len, 64 * 1024);
>
> -}
> int dummy_spi_write_256(struct flashchip *flash, uint8_t *buf, int start, int len)
> {
>  return spi_write_chunked(flash, buf, start, len,

Any reason you didn't kill dummy_write_256()? If you kill it, please 
remove it from programmer.h and adjust SPI_CONTROLLER_DUMMY in spi.c 
accordingly. Thanks.

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH 1/3] Factor out SPI write/read chunking wrappers.

[Michael Karcher]

Am Donnerstag, den 05.05.2011, 20:47 +0200 schrieb Carl-Daniel
Hailfinger:
> > int dummy_spi_write_256(struct flashchip *flash, uint8_t *buf, int start, int len)
> >   {
> >    return spi_write_chunked(flash, buf, start, len,
>
> Any reason you didn't kill dummy_write_256()?

Yes, the reason is that the dummyflasher has a variable maximal chunk
size specified on the command line, so no constant value can do. Of
course patching the programmer structure instead and using the default
write function is an option.

Regards,
  Michael Karcher

[PATCH 1/3] Factor out SPI write/read chunking wrappers.

[Carl-Daniel Hailfinger]

Am 06.05.2011 12:05 schrieb Michael Karcher:
> Am Donnerstag, den 05.05.2011, 20:47 +0200 schrieb Carl-Daniel
> Hailfinger:
> > > int dummy_spi_write_256(struct flashchip *flash, uint8_t *buf, int start, int len)
> > >    {
> > >    	return spi_write_chunked(flash, buf, start, len,
> >
> > Any reason you didn't kill dummy_write_256()?
>
> Yes, the reason is that the dummyflasher has a variable maximal chunk
> size specified on the command line, so no constant value can do.

OK.
> Of course patching the programmer structure instead and using the default
> write function is an option.

That would be nice, but it can be done as followup. I'd like to see your 
patch merged ASAP.

Regards,
Carl-Daniel

[PATCH 1/3] Factor out SPI write/read chunking wrappers.

[Michael Karcher]

Am Donnerstag, den 05.05.2011, 20:47 +0200 schrieb Carl-Daniel
Hailfinger:
> Acked-by: Carl-Daniel Hailfinger

Thanks for reviewing and acknowledging, this is r1298.

Regards,
  Michael Karcher