Re: [flashrom] [PATCH] Some c99 fixes.

[Carl-Daniel Hailfinger]

Am 27.08.2012 01:34 schrieb Stefan Tauner:
> This patch just fixes a limited number of bits not conforming to c99 by using
> __asm__ instead of just asm
> {0} instead of {} for struct initialization
> h_addr_list[0] instead of h_addr to access the host address in
> struct hostent
> #include <strings.h> where needed (for ffs and strcasecmp)
>
> Signed-off-by: Stefan Tauner 
> Acked-by: Carl-Daniel Hailfinger

Cross-compilation with mingw64 and djgpp tested, works as well as
without the patch.

You might want to call the patch "C11 fixes" instead because some
complaints disappear in C11 mode. Your choice.

Regards,
Carl-Daniel

[PATCH] Some c99 fixes.

[Stefan Tauner]

On Mon, 27 Aug 2012 01:47:39 +0200
Carl-Daniel Hailfinger  wrote:
> Am 27.08.2012 01:34 schrieb Stefan Tauner:
> > This patch just fixes a limited number of bits not conforming to c99 by using
> > __asm__ instead of just asm
> > {0} instead of {} for struct initialization
> > h_addr_list[0] instead of h_addr to access the host address in
> > struct hostent
> > #include <strings.h> where needed (for ffs and strcasecmp)
> >
> > Signed-off-by: Stefan Tauner 
> > Acked-by: Carl-Daniel Hailfinger
>
> Cross-compilation with mingw64 and djgpp tested, works as well as
> without the patch.

yay, thanks
committed in r1585.