Re: [flashrom] Add PICkit2 as an SPI programmer

[Justin Chevrier]

The patch as committed works fine here (only tested read). In
addition, I tried other voltage values (eg. 2.9V, 3.3V, 3.1V) beyond
the 3 currently supported and the hardware happily sets those voltages
as well.

Thanks again,

Justin

On Sun, Feb 8, 2015 at 6:23 PM, Justin Chevrier  wrote:
> Hey Stefan,
>
> Apologies for the late response.
>
> voltage=0V along with the 3 voltage levels was basically just a matter
> of doing the same thing as the Dediprog code. The 3 voltage levels in
> particular made sense as I assumed that covered all current SPI chips.
> I'm not sure what the hardware will do if other values are chosen,
> although you've piqued my interest. If someone else doesn't beat me to
> it, I'll try out the committed (thanks btw) version of the patch and
> attempt setting other voltages.
>
> Justin
>
> On Sat, Jan 31, 2015 at 9:56 PM, Stefan Tauner
>  wrote:
> > On Fri, 26 Dec 2014 20:53:47 -0500
> > Justin Chevrier  wrote:
> > > Hi Stefan,
> > >
> > > It seems you're correct. Signed off is below.
> > >
> > > Signed-off-by: Justin Chevrier
> >
> > Does the option to set voltage=0V really make sense? But since this is
> > even possible... I would rather set it to 0V at shutdown. If that turns
> > off the drivers completely it might be very useful while doing
> > in-circuit programming because the programmer could remain attached
> > even when the target is running.
> >
> > Why do we restrict the levels to 3 values although the API seems to
> > allow to transmit a much finer resolution? What does the hardware
> > actually do with these values?