[PATCH] Fix M25P05

[serge]

With this patch M25P05 chip was sucessfully tested (full read/erase/write)

Signed-off-by: Serge Vasilugin

--- flashchips.h.orig
+++ flashchips.h
@@ -748,9 +748,9 @@
   */
  #define ST_ID			0x20	/* ST / SGS/Thomson / Numonyx (later acquired by 
Micron) */
  #define ST_M25P05A		0x2010
-#define ST_M25P05_RES		0x10	/* Same code as M25P10. */
+#define ST_M25P05_RES		0x05
  #define ST_M25P10A		0x2011
-#define ST_M25P10_RES		0x10	/* Same code as M25P05. */
+#define ST_M25P10_RES		0x10
  #define ST_M25P20		0x2012
  #define ST_M25P20_RES		0x11
  #define ST_M25P40		0x2013

[Stefan Tauner]

On Mon, 06 Jun 2016 22:40:51 +0600
serge  wrote:
> With this patch M25P05 chip was sucessfully tested (full read/erase/write)
>
> Signed-off-by: Serge Vasilugin
>
> --- flashchips.h.orig
> +++ flashchips.h
> @@ -748,9 +748,9 @@
>    */
>   #define ST_ID			0x20	/* ST / SGS/Thomson / Numonyx (later acquired by 
> Micron) */
>   #define ST_M25P05A		0x2010
> -#define ST_M25P05_RES		0x10	/* Same code as M25P10. */
> +#define ST_M25P05_RES		0x05
>   #define ST_M25P10A		0x2011
> -#define ST_M25P10_RES		0x10	/* Same code as M25P05. */
> +#define ST_M25P10_RES		0x10
>   #define ST_M25P20		0x2012
>   #define ST_M25P20_RES		0x11
>   #define ST_M25P40		0x2013

Hello Serge,

thanks for your patch! We have added the "wrong" definition on purpose
because it is noted so in the respective datasheet and we did not have
the flash chip physically to test it. Can you please provide the exact
model name printed on the chip and if possible also a verbose log of
flashrom probing for the chip (with or without your patch)?

[Сергей Василюгин]

11.06.2016, 16:20, "Stefan Tauner" :
> On Mon, 06 Jun 2016 22:40:51 +0600
> serge  wrote:
> > With this patch M25P05 chip was sucessfully tested (full read/erase/write)
> >
> > Signed-off-by: Serge Vasilugin
> >
> > --- flashchips.h.orig
> >  +++ flashchips.h
> >  @@ -748,9 +748,9 @@
> >     */
> >    #define ST_ID 0x20 /* ST / SGS/Thomson / Numonyx (later acquired by
> >  Micron) */
> >    #define ST_M25P05A 0x2010
> >  -#define ST_M25P05_RES 0x10 /* Same code as M25P10. */
> >  +#define ST_M25P05_RES 0x05
> >    #define ST_M25P10A 0x2011
> >  -#define ST_M25P10_RES 0x10 /* Same code as M25P05. */
> >  +#define ST_M25P10_RES 0x10
> >    #define ST_M25P20 0x2012
> >    #define ST_M25P20_RES 0x11
> >    #define ST_M25P40 0x2013
>
> Hello Serge,
>
> thanks for your patch! We have added the "wrong" definition on purpose
> because it is noted so in the respective datasheet and we did not have
> the flash chip physically to test it. Can you please provide the exact
> model name printed on the chip and if possible also a verbose log of
> flashrom probing for the chip (with or without your patch)?
> --
> Kind regards/Mit freundlichen Grüßen, Stefan Tauner

Photo of chip and log of patched flashrom are attached.

---
serge

[Stefan Tauner]

Thank you very much. Although the marking seems to indicate that it is
an M25P05A I believe you are right and it indeed is an M25P05 chip
because of the missing RDID replies... if no one persuades me otherwise
I'll merge your change soon, thanks!