Re: [flashrom] [PATCH 1/3] resort chipset_enables array by pci ids

[Uwe Hermann]

On Mon, Jun 13, 2011 at 10:44:42PM +0200, Stefan Tauner wrote:
> Signed-off-by: Idwer Vollering 
> Signed-off-by: Stefan Tauner
>
> chipset_enable.c |  210 +++++++++++++++++++++++++++---------------------------
>  1 files changed, 105 insertions(+), 105 deletions(-)
>
> diff --git a/chipset_enable.c b/chipset_enable.c
> index 60d5d4d..3a2febc 100644
> --- a/chipset_enable.c
> +++ b/chipset_enable.c
> @@ -1009,80 +1009,50 @@ static int get_flashbase_sc520(struct pci_dev *dev, const char *name)
>
> #endif
>
> -/* Please keep this list alphabetically sorted by vendor/device. */
> +/* Please keep this list numerically sorted by vendor/device. */

^^^^^^^^^^^^^
                              Make this "vendor/device ID" please.

Other than that this is
Acked-by: Uwe Hermann

Uwe.

[PATCH 1/3] resort chipset_enables array by pci ids

[Stefan Tauner]

On Sat, 18 Jun 2011 14:34:06 +0200
Uwe Hermann  wrote:
> On Mon, Jun 13, 2011 at 10:44:42PM +0200, Stefan Tauner wrote:
> > Signed-off-by: Idwer Vollering 
> > Signed-off-by: Stefan Tauner
> >
> > chipset_enable.c |  210 +++++++++++++++++++++++++++---------------------------
> >  1 files changed, 105 insertions(+), 105 deletions(-)
> >
> > diff --git a/chipset_enable.c b/chipset_enable.c
> > index 60d5d4d..3a2febc 100644
> > --- a/chipset_enable.c
> > +++ b/chipset_enable.c
> > @@ -1009,80 +1009,50 @@ static int get_flashbase_sc520(struct pci_dev *dev, const char *name)
> >
> > #endif
> >
> > -/* Please keep this list alphabetically sorted by vendor/device. */
> > +/* Please keep this list numerically sorted by vendor/device. */
>                                               ^^^^^^^^^^^^^
>                           Make this "vendor/device ID" please.
>
> Other than that this is
> Acked-by: Uwe Hermann

thanks. fixed and comitted in r1342