Re: [flashrom] [PATCH] Unify PCI init and let pcidev clean itself up.

[Carl-Daniel Hailfinger]

Am 02.01.2013 15:43 schrieb Stefan Tauner:
> Previously the internal programmer used its own code to initialize pcilib.
> This patch extracts the common code from the internal programmer and
> pcidev_init() into pcidev_init_common().
> This fixes the non-existent PCI cleanup of the internal programmer and adds
> an additional safety by checking for an already existing PCI context.
>
> We got a nice shutdown function registration infrastructure, but did not use it
> very wisely. Instead we added shutdown functions to a myriad of programmers
> unnecessarily. In this patch we get rid of those that do only call pci_cleanup(pacc)
> by adding a shutdown function the pcidev.c itself that gets registered by
> pcidev_init().
>
> Signed-off-by: Stefan Tauner

Great work!
Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[PATCH] Unify PCI init and let pcidev clean itself up.

[Stefan Tauner]

On Wed, 02 Jan 2013 18:58:16 +0100
Carl-Daniel Hailfinger  wrote:
> Great work!
> Acked-by: Carl-Daniel Hailfinger

Thanks :) r1642