Re: [flashrom] Add support for Micronix MX29F022(N)T

[Stefan Tauner]

On Fri, 4 Jul 2014 23:30:39 +0200
Daniele Forsi  wrote:
> Hello,

Hello Daniele,

thanks for your patch!
> I successfully tested the following patch with read, erase and write
> but I don't know how do I choose a value for .page_size?

you don't if you dont have to, and i think it is not necessary in your
case. that field will be removed in the future.
i suggest that you use ".page_size	= 0, /* unused */"

There is only one major problem with your patch: it got mangled before
sending (probably by your MUA). Can you please resend it properly?

[PATCH v2] Add support for Macronix MX29F022(N)T

I successfully tested the following patch with read, erase and write.
I set .page_size to 0.

Signed-off-by: Daniele Forsi

Index: flashchips.c
===================================================================
--- flashchips.c	(revision 1822)
+++ flashchips.c	(working copy)
@@ -6996,6 +6996,38 @@

{
    	.vendor		= "Macronix",
+		.name		= "MX29F022(N)T",
+		.bustype	= BUS_PARALLEL,
+		.manufacture_id	= MACRONIX_ID,
+		.model_id	= MACRONIX_MX29F022T,
+		.total_size	= 256,
+		.page_size	= 0, /* unused */
+		.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
+		.tested		= TEST_OK_PREW,
+		.probe		= probe_jedec,
+		.probe_timing	= TIMING_ZERO,
+		.block_erasers	=
+		{
+			{
+				.eraseblocks = {
+					{64 * 1024, 3},
+					{32 * 1024, 1},
+					{8 * 1024, 2},
+					{16 * 1024, 1},
+				},
+				.block_erase = erase_sector_jedec,
+			}, {
+				.eraseblocks = { {256 * 1024, 1} },
+				.block_erase = erase_chip_block_jedec,
+			}
+		},
+		.write		= write_jedec_1,
+		.read		= read_memmapped,
+		.voltage	= {4500, 5500},
+	},
+
+	{
+		.vendor		= "Macronix",
    	.name		= "MX29F040",
    	.bustype	= BUS_PARALLEL,
    	.manufacture_id	= MACRONIX_ID,

[PATCH v2] Add support for Macronix MX29F022(N)T

[Stefan Tauner]

On Fri, 11 Jul 2014 07:25:35 -0700 (PDT)
[e-mail] wrote:
> I successfully tested the following patch with read, erase and write.
> I set .page_size to 0.
>
> Signed-off-by: Daniele Forsi

Thank you! I have also added the MX29F022(N)B because that was trivial.
The resulting change was committed in r1825.