[PATCH] Update the flashrom manpage

[Uwe Hermann]

See patch.

Uwe.

[Stefan Tauner]

On Tue, 14 Jun 2011 01:06:13 +0200
Uwe Hermann  wrote:
> See patch.

nicintel and nicintel_spi are far apart from each other in the list,
which is probably ok because the list seems to be divided in non-spi
and spi programmers (which maybe should be indicated somehow).
it seems to be unsorted apart from that.
later in the paragraph describing the pci= option the order is
different. maybe we should introduce some consistent order?
besides that i think your changes are ok.

can we merge this with the (somewhat hidden) manpage patch from andrew
(http://patchwork.coreboot.org/patch/3109/)?
i have attached a patch which has yours merged with andrew's with a
small additional change (line 411), and i have added myself to the list
of authors.

[Uwe Hermann]

On Tue, Jun 14, 2011 at 03:36:30PM +0200, Stefan Tauner wrote:
> nicintel and nicintel_spi are far apart from each other in the list,
> which is probably ok because the list seems to be divided in non-spi
> and spi programmers (which maybe should be indicated somehow).
> it seems to be unsorted apart from that.
> later in the paragraph describing the pci= option the order is
> different. maybe we should introduce some consistent order?

Yeah, we could think about that, right now most lists (also in Makefile,
etc) of programmers are mostly unsorted. But that should be a different patch.
Not really high priority, though.
> besides that i think your changes are ok.
>
> can we merge this with the (somewhat hidden) manpage patch from andrew
> (http://patchwork.coreboot.org/patch/3109/)?
> i have attached a patch which has yours merged with andrew's with a
> small additional change (line 411), and i have added myself to the list
> of authors.

Looks good.

Acked-by: Uwe Hermann

Uwe.

[Stefan Tauner]

On Wed, 15 Jun 2011 21:21:47 +0200
Uwe Hermann  wrote:
> On Tue, Jun 14, 2011 at 03:36:30PM +0200, Stefan Tauner wrote:
> > nicintel and nicintel_spi are far apart from each other in the list,
> > which is probably ok because the list seems to be divided in non-spi
> > and spi programmers (which maybe should be indicated somehow).
> > it seems to be unsorted apart from that.
> > later in the paragraph describing the pci= option the order is
> > different. maybe we should introduce some consistent order?
>
> Yeah, we could think about that, right now most lists (also in Makefile,
> etc) of programmers are mostly unsorted. But that should be a different patch.
> Not really high priority, though.

i agree. i don't think it matters much, i just thought it may be a good
idea to reorder it when we touch the manpage in one commit...
> > besides that i think your changes are ok.
> >
> > can we merge this with the (somewhat hidden) manpage patch from andrew
> > (http://patchwork.coreboot.org/patch/3109/)?
> > i have attached a patch which has yours merged with andrew's with a
> > small additional change (line 411), and i have added myself to the list
> > of authors.
>
> Looks good.
>
> Acked-by: Uwe Hermann

thanks, r1339.