[PATCH] add support for SIS661 (SIS963)

[David Borg]

Tested on P4S800-MX

Index: chipset_enable.c
===================================================================
--- chipset_enable.c    (revision 1127)
+++ chipset_enable.c    (working copy)
@@ -1116,6 +1116,7 @@
     {0x1039, 0x0650, NT, "SiS", "650",        enable_flash_sis540},
     {0x1039, 0x0651, NT, "SiS", "651",        enable_flash_sis540},
     {0x1039, 0x0655, NT, "SiS", "655",        enable_flash_sis540},
+    {0x1039, 0x0661, OK, "SiS", "661",        enable_flash_sis540},
     {0x1039, 0x0730, NT, "SiS", "730",        enable_flash_sis540},
     {0x1039, 0x0733, NT, "SiS", "733",        enable_flash_sis540},
     {0x1039, 0x0735, OK, "SiS", "735",        enable_flash_sis540},

Signed-off-by: David Borg

On 28 July 2010 03:06, David Borg  wrote:
> Updated the patch to remove anything related to chip  (un)locking, as there
> is no way to unlock the superio except by a cold reset.
>
> Logs for the different flashrom runs and the outputs of lspci -nnvvvxxx and
> superiotool -deV are also attached.
>
> w836xx_memw_enable will work for this board, however i'd still like to see
> the function corrected for completeness sake. I haven't yet found a
> datasheet for a superio in the w83627 family where the function is correct,
> and the supported superio's all work with sio_mask(port, 0x24, 0x28, 0x38);
> Perhaps it should be fixed in a separate patch?
>
> Regards,
> David
>
> On 1 July 2010 11:50, David Borg  wrote:
> > Patch to add support for the Asus P4S800-MX motherboard and SIS 963
> > chipset. Invalidates previous patch: [PATCH] add support for SIS963
> >
> > If anyone has the output of superiotool -deV for the following working
> > boards, please forward them, so I can merge the functions
> > w836xx_unlock_memw_enable_2e and w836xx_memw_enable_2e, and maybe fix
> > the function w836xx_memw_enable which I believe has a typo, such that
> >                sio_mask(port, 0x24, 0x28, 0x28);
> > becomes : sio_mask(port, 0x24, 0x28, 0x38);
> >
> > Motherboards:
> > Albatron - PM266A Pro
> > ASUS - A7V8X-MX SE
> > EPoX - EP-8K5A2
> > Shuttle - AK31
> > Tyan - S2498 (Tomcat K7M)
> > Termtek - TK-3370 (Rev:2.5B)
> > MSI - MS-6590 (KT4 Ultra)
> > MSI - MS-6712 (KT4V)
> > MSI - MS-7005 (651M-L)
> >
> > Signed-off-by: David Borg
> >
> > Regards,
> > David

[Carl-Daniel Hailfinger]

On 30.07.2010 19:30, David Borg wrote:
> Tested on P4S800-MX
> Index: chipset_enable.c
>
> --- chipset_enable.c    (revision 1127)
> +++ chipset_enable.c    (working copy)
> @@ -1116,6 +1116,7 @@
>      {0x1039, 0x0650, NT, "SiS", "650",        enable_flash_sis540},
>      {0x1039, 0x0651, NT, "SiS", "651",        enable_flash_sis540},
>      {0x1039, 0x0655, NT, "SiS", "655",        enable_flash_sis540},
> {0x1039, 0x0661, OK, "SiS", "661",        enable_flash_sis540},
> {0x1039, 0x0730, NT, "SiS", "730",        enable_flash_sis540},
> {0x1039, 0x0733, NT, "SiS", "733",        enable_flash_sis540},
> {0x1039, 0x0735, OK, "SiS", "735",        enable_flash_sis540},

Thanks for your patch.
Apparently your mailer corrupts whitespace (or you cut-n-pasted from a
console which corrupts whitespace), so I had to fix it up manually.
> Signed-off-by: David Borg

Acked-by: Carl-Daniel Hailfinger 
and committed in r1128.

Regards,
Carl-Daniel