Re: [flashrom] [commit] r772 - trunk

[Stefan Reinauer]

[e-mail] wrote:
> +ifeq ($(CONFIG_BUSPIRATESPI), yes)
> +FEATURE_CFLAGS += -D'BUSPIRATE_SPI_SUPPORT=1'
> +OBJS += buspirate_spi.o
> +endif
>
> +# Ugly, but there's no elif/elseif.
>  ifeq ($(CONFIG_SERPROG), yes)
>  OBJS += serial.o
> +else
> +ifeq ($(CONFIG_BUSPIRATESPI), yes)
> +OBJS += serial.o
>  endif
> +endif

how long before we see Kconfig? ;-)

[commit] r772 - trunk

[Carl-Daniel Hailfinger]

On 24.11.2009 01:29, Stefan Reinauer wrote:
> [e-mail] wrote:
> > +ifeq ($(CONFIG_BUSPIRATESPI), yes)
> > +FEATURE_CFLAGS += -D'BUSPIRATE_SPI_SUPPORT=1'
> > +OBJS += buspirate_spi.o
> > +endif
> >
> > +# Ugly, but there's no elif/elseif.
> >  ifeq ($(CONFIG_SERPROG), yes)
> >  OBJS += serial.o
> > +else
> > +ifeq ($(CONFIG_BUSPIRATESPI), yes)
> > +OBJS += serial.o
> >  endif
> > +endif
>
> how long before we see Kconfig? ;-)

I'm thinking of a simple sh configure script. That would clean up quite
a few parts of the Makefile and remove a ton of ugly hacks.
Kconfig is not on my radar yet, AFAICS it is larger than the rest of the
code combined.

Regards,
Carl-Daniel