Oops, disregard that last message. I was looking at find_romentry() and indeed it makes sense to return a negative value to indicate error since it returns an index otherwise.
Acked-by: David Hendricks dhendrix@google.com
On Fri, Aug 19, 2011 at 2:53 PM, David Hendricks dhendrix@google.comwrote:
Did you want to fix the inconsistent use of -1 instead of 1 as the return code for some functions?
Other than that it looks good (i'm biased, of course :-))
-- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.