Oops, disregard that last message. I was looking at <span class="Apple-style-span" style="color: rgb(51, 51, 51); font-family: arial, sans-serif; font-size: 13px; background-color: rgb(255, 255, 255); ">find_romentry() and indeed it makes sense to return a negative value to indicate error since it returns an index otherwise.</span><div>

<font class="Apple-style-span" color="#333333" face="arial, sans-serif"><br></font></div><div><font class="Apple-style-span" color="#333333" face="arial, sans-serif">Acked-by: David Hendricks &lt;<a href="mailto:dhendrix@google.com">dhendrix@google.com</a>&gt;<br>

</font><br><div class="gmail_quote">On Fri, Aug 19, 2011 at 2:53 PM, David Hendricks <span dir="ltr">&lt;<a href="mailto:dhendrix@google.com">dhendrix@google.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

<div class="gmail_quote">Did you want to fix the inconsistent use of -1 instead of 1 as the return code for some functions?</div><div class="gmail_quote"><br></div><div class="gmail_quote">Other than that it looks good (i&#39;m biased, of course :-))</div>



<div class="gmail_quote"><br></div><span class="HOEnZb"><font color="#888888">-- <br>David Hendricks (dhendrix)<br>Systems Software Engineer, Google Inc.<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>David Hendricks (dhendrix)<br>Systems Software Engineer, Google Inc.<br>
</div>