flashrom

flashrom@flashrom.org

5 participants
9161 discussions

[PATCH] Check if 82802ab probe reads real IDs
by Carl-Daniel Hailfinger 23 Mar '10

23 Mar '10

JEDEC ID probing checks the parity of the vendor ID and verifies that the ID differs from the flash chip contents. Add the same feature to 82802AB ID probing. This should reduce the number of lines we have to look at to determine if we're missing a chip definition or if we need a board enable. Just use grep on the log: grep -v "parity violation" To narrow it down further, try: grep -v "id1 is normal flash content, id2 is normal flash content" And of course you want to ignore the skipped probes: grep -v "skipped" The remaining lines are worth examining, and if those look bogus as well, you can bet that we just need a board enable. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-82802ab_probe_check_parity/82802ab.c =================================================================== --- flashrom-82802ab_probe_check_parity/82802ab.c (Revision 969) +++ flashrom-82802ab_probe_check_parity/82802ab.c (Arbeitskopie) @@ -47,6 +47,7 @@ { chipaddr bios = flash->virtual_memory; uint8_t id1, id2; + uint8_t flashcontent1, flashcontent2; /* Reset to get a clean state */ chip_writeb(0xFF, bios); @@ -64,8 +65,21 @@ programmer_delay(10); - printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __func__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x", __func__, id1, id2); + if (!oddparity(id1)) + printf_debug(", id1 parity violation"); + + /* Read the product ID location again. We should now see normal flash contents. */ + flashcontent1 = chip_readb(bios); + flashcontent2 = chip_readb(bios + 0x01); + + if (id1 == flashcontent1) + printf_debug(", id1 is normal flash content"); + if (id2 == flashcontent2) + printf_debug(", id2 is normal flash content"); + + printf_debug("\n"); if (id1 != flash->manufacture_id || id2 != flash->model_id) return 0; -- http://www.hailfinger.org/

2 2

[commit] r971 - trunk
by repository service 23 Mar '10

23 Mar '10

Author: hailfinger Date: Tue Mar 23 00:47:38 2010 New Revision: 971 URL: http://flashrom.org/trac/coreboot/changeset/971 Log: JEDEC ID probing checks the parity of the vendor ID and verifies that the ID differs from the flash chip contents. Add the same feature to 82802AB ID probing. This should reduce the number of lines we have to look at to determine if we're missing a chip definition or if we need a board enable. Just use grep on the log: grep -v "parity violation" To narrow it down further, try: grep -v "id1 is normal flash content, id2 is normal flash content" And of course you want to ignore the skipped probes: grep -v "skipped" The remaining lines are worth examining, and if those look bogus as well, you can bet that we just need a board enable. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> Modified: trunk/82802ab.c Modified: trunk/82802ab.c ============================================================================== --- trunk/82802ab.c Tue Mar 23 00:43:51 2010 (r970) +++ trunk/82802ab.c Tue Mar 23 00:47:38 2010 (r971) @@ -47,6 +47,7 @@ { chipaddr bios = flash->virtual_memory; uint8_t id1, id2; + uint8_t flashcontent1, flashcontent2; /* Reset to get a clean state */ chip_writeb(0xFF, bios); @@ -64,8 +65,21 @@ programmer_delay(10); - printf_debug("%s: id1 0x%02x, id2 0x%02x\n", __func__, id1, id2); + printf_debug("%s: id1 0x%02x, id2 0x%02x", __func__, id1, id2); + if (!oddparity(id1)) + printf_debug(", id1 parity violation"); + + /* Read the product ID location again. We should now see normal flash contents. */ + flashcontent1 = chip_readb(bios); + flashcontent2 = chip_readb(bios + 0x01); + + if (id1 == flashcontent1) + printf_debug(", id1 is normal flash content"); + if (id2 == flashcontent2) + printf_debug(", id2 is normal flash content"); + + printf_debug("\n"); if (id1 != flash->manufacture_id || id2 != flash->model_id) return 0;

1 0

[PATCH] Reduce message severity level for skipped chips
by Carl-Daniel Hailfinger 23 Mar '10

23 Mar '10

Old verbose log excerpt: Probing for Atmel AT25DF021, 256 KB: skipped. Host bus type Parallel and chip bus type SPI are incompatible. New verbose log excerpt: Probing for Atmel AT25DF021, 256 KB: skipped. This makes logs more readable and manageable. If someone really desperately wants all the bus debugging stuff, he/she can switch to SPEW mode instead of VERBOSE mode. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-skip_bus_nonverbose/flashrom.c =================================================================== --- flashrom-skip_bus_nonverbose/flashrom.c (Revision 969) +++ flashrom-skip_bus_nonverbose/flashrom.c (Arbeitskopie) @@ -877,20 +877,24 @@ for (flash = first_flash; flash && flash->name; flash++) { if (chip_to_probe && strcmp(flash->name, chip_to_probe) != 0) continue; - printf_debug("Probing for %s %s, %d KB: ", + msg_gdbg("Probing for %s %s, %d KB: ", flash->vendor, flash->name, flash->total_size); if (!flash->probe && !force) { - printf_debug("failed! flashrom has no probe function for this flash chip.\n"); + msg_gdbg("failed! flashrom has no probe function for " + "this flash chip.\n"); continue; } buses_common = buses_supported & flash->bustype; if (!buses_common) { tmp = flashbuses_to_text(buses_supported); - printf_debug("skipped. Host bus type %s ", tmp); + msg_gdbg("skipped."); + msg_gspew(" Host bus type %s ", tmp); free(tmp); tmp = flashbuses_to_text(flash->bustype); - printf_debug("and chip bus type %s are incompatible.\n", tmp); + msg_gspew("and chip bus type %s are incompatible.", + tmp); free(tmp); + msg_gdbg("\n"); continue; } -- "I do consider assignment statements and pointer variables to be among computer science's most valuable treasures." -- Donald E. Knuth

2 2

[commit] r970 - trunk
by repository service 23 Mar '10

23 Mar '10

Author: hailfinger Date: Tue Mar 23 00:43:51 2010 New Revision: 970 URL: http://flashrom.org/trac/coreboot/changeset/970 Log: Reduce message severity level for skipped chips. Old verbose log excerpt: Probing for Atmel AT25DF021, 256 KB: skipped. Host bus type Parallel and chip bus type SPI are incompatible. New verbose log excerpt: Probing for Atmel AT25DF021, 256 KB: skipped. This makes logs more readable and manageable. If someone really desperately wants all the bus debugging stuff, he/she can switch to SPEW mode instead of VERBOSE mode. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-By: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> Modified: trunk/flashrom.c Modified: trunk/flashrom.c ============================================================================== --- trunk/flashrom.c Mon Mar 22 22:48:51 2010 (r969) +++ trunk/flashrom.c Tue Mar 23 00:43:51 2010 (r970) @@ -877,20 +877,24 @@ for (flash = first_flash; flash && flash->name; flash++) { if (chip_to_probe && strcmp(flash->name, chip_to_probe) != 0) continue; - printf_debug("Probing for %s %s, %d KB: ", + msg_gdbg("Probing for %s %s, %d KB: ", flash->vendor, flash->name, flash->total_size); if (!flash->probe && !force) { - printf_debug("failed! flashrom has no probe function for this flash chip.\n"); + msg_gdbg("failed! flashrom has no probe function for " + "this flash chip.\n"); continue; } buses_common = buses_supported & flash->bustype; if (!buses_common) { tmp = flashbuses_to_text(buses_supported); - printf_debug("skipped. Host bus type %s ", tmp); + msg_gdbg("skipped."); + msg_gspew(" Host bus type %s ", tmp); free(tmp); tmp = flashbuses_to_text(flash->bustype); - printf_debug("and chip bus type %s are incompatible.\n", tmp); + msg_gspew("and chip bus type %s are incompatible.", + tmp); free(tmp); + msg_gdbg("\n"); continue; }

1 0

[PATCH] fix a r943 missmerge, a duplicate printlock
by Sean Nelson 22 Mar '10

22 Mar '10

Clang complains loudly when there are duplicate printlock_sst_fwhub, gcc ignores them. Ack via IRC. Signed-off-by: Sean Nelson <audiohacked(a)gmail.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>

2 3

[commit] r969 - trunk
by repository service 22 Mar '10

22 Mar '10

Author: snelson Date: Mon Mar 22 22:48:51 2010 New Revision: 969 URL: http://flashrom.org/trac/coreboot/changeset/969 Log: Clang complains loudly when there are duplicate printlock_sst_fwhub, gcc ignores them. Ack via IRC. Signed-off-by: Sean Nelson <audiohacked(a)gmail.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/flashchips.c Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Mon Mar 22 13:29:45 2010 (r968) +++ trunk/flashchips.c Mon Mar 22 22:48:51 2010 (r969) @@ -4096,7 +4096,6 @@ } }, .printlock = printlock_sst_fwhub, - .printlock = printlock_sst_fwhub, .unlock = unlock_sst_fwhub, .write = write_jedec_1, .read = read_memmapped, @@ -4128,7 +4127,6 @@ } }, .printlock = printlock_sst_fwhub, - .printlock = printlock_sst_fwhub, .unlock = unlock_sst_fwhub, .write = write_jedec_1, .read = read_memmapped, @@ -4163,7 +4161,6 @@ }, }, .printlock = printlock_sst_fwhub, - .printlock = printlock_sst_fwhub, .unlock = unlock_sst_fwhub, .write = write_jedec_1, .read = read_memmapped, @@ -4226,7 +4223,6 @@ } }, .printlock = printlock_sst_fwhub, - .printlock = printlock_sst_fwhub, .unlock = unlock_sst_fwhub, .write = write_jedec_1, .read = read_memmapped,

1 0

[PATCH] More robust libpci detection
by Carl-Daniel Hailfinger 22 Mar '10

22 Mar '10

Idwer reported problems with the current libpci check on FreeBSD 8.0-RELEASE i386 This is caused by a strict linker. Parsing linker error messages is an exercise in futility, so I implemented fallback library detection with $CC --print-file-name. This fallback will fail on llvm-clang (llvm bug 5137), but such machines hopefully have a more permissive linker and will never hit that code path. The fallback will also fail on NetBSD where we should look for libpciutils instead, but that hopefully doesn't have a strict linker either. Side note: The configure checks in the Makefile are now so unwieldy that a separate configure script will definitely improve readability. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-libpci_robust_detection/Makefile =================================================================== --- flashrom-libpci_robust_detection/Makefile (Revision 916) +++ flashrom-libpci_robust_detection/Makefile (Arbeitskopie) @@ -251,21 +251,30 @@ echo "Please install libpci headers (package pciutils-devel)."; \ echo "See README for more information."; echo; \ rm -f .test.c .test.o; exit 1) - @printf "Checking for libpci... " + @printf "Checking for libpci (method 1)... " @$(shell ( echo "#include <pci/pci.h>"; \ echo "int main(int argc, char **argv)"; \ echo "{ return 0; }"; ) > .test1.c ) - @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .test1.c -o .test1 -lpci $(LIBS) >/dev/null 2>&1 && \ - echo "found." || ( echo "not found."; echo; \ - echo "Please install libpci (package pciutils)."; \ - echo "See README for more information."; echo; \ - rm -f .test1.c .test1; exit 1) + @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .test1.c -o .test1 $(LIBS) >/dev/null 2>&1 && \ + echo "found." || ( echo "not found."; \ + $(CC) --print-file-name=libpci.so >/dev/null 2>&1 && ( \ + printf "Checking for dynamic libpci (method 2)... "; \ + $(CC) --print-file-name=libpci.so 2>/dev/null | grep -q / && \ + echo "found." || ( echo "not found."; \ + printf "Checking for static libpci (method 2)... " \ + $(CC) --print-file-name=libpci.a 2>/dev/null | grep -q / && \ + echo "found." || ( echo "not found."; echo; \ + echo "Please install libpci (package pciutils)."; \ + echo "See README for more information."; echo; \ + rm -f .test1.c .test1; exit 1) ) ) || ( echo "unavailable."; echo; \ + echo "Please install libpci (package pciutils)."; \ + echo "See README for more information."; echo; )) @printf "Checking if libpci is sufficient... " @printf "" > .libdeps - @$(CC) $(LDFLAGS) .test.o -o .test -lpci $(LIBS) >/dev/null 2>&1 && \ + @$(CC) $(LDFLAGS) .test.o -o .test $(LIBS) >/dev/null 2>&1 && \ echo "yes." || ( echo "no."; \ printf "Checking if libz is present and supplies all needed symbols..."; \ - $(CC) $(LDFLAGS) .test.o -o .test -lpci -lz $(LIBS) >/dev/null 2>&1 && \ + $(CC) $(LDFLAGS) .test.o -o .test $(LIBS) -lz >/dev/null 2>&1 && \ ( echo "yes."; echo "NEEDLIBZ := yes" > .libdeps ) || ( echo "no."; echo; \ echo "Please install libz."; \ echo "See README for more information."; echo; \ -- "I do consider assignment statements and pointer variables to be among computer science's most valuable treasures." -- Donald E. Knuth

3 7

[commit] r968 - trunk
by repository service 22 Mar '10

22 Mar '10

Author: hailfinger Date: Mon Mar 22 13:29:45 2010 New Revision: 968 URL: http://flashrom.org/trac/coreboot/changeset/968 Log: Idwer Vollering reported problems with the current libpci check on FreeBSD 8.0-RELEASE i386 This is caused by a strict linker. Parsing linker error messages is an exercise in futility, and library detection with $CC --print-file-name is totally useless for libraries outside the standard hardcoded builtin gcc search path (probably the same for other compilers as well). Look for libpciutils instead of libpci on NetBSD during the check. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Idwer Vollering <vidwer(a)gmail.com> Modified: trunk/Makefile Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Mon Mar 22 08:03:26 2010 (r967) +++ trunk/Makefile Mon Mar 22 13:29:45 2010 (r968) @@ -279,26 +279,17 @@ echo "Please install libpci headers (package pciutils-devel)."; \ echo "See README for more information."; echo; \ rm -f .test.c .test.o; exit 1) - @printf "Checking for libpci... " - @$(shell ( echo "#include <pci/pci.h>"; \ - echo "int main(int argc, char **argv)"; \ - echo "{ return 0; }"; ) > .test1.c ) - @$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .test1.c -o .test1 -lpci $(LIBS) >/dev/null 2>&1 && \ - echo "found." || ( echo "not found."; echo; \ - echo "Please install libpci (package pciutils)."; \ - echo "See README for more information."; echo; \ - rm -f .test1.c .test1; exit 1) - @printf "Checking if libpci is sufficient... " + @printf "Checking if libpci is present and sufficient... " @printf "" > .libdeps - @$(CC) $(LDFLAGS) .test.o -o .test -lpci $(LIBS) >/dev/null 2>&1 && \ + @$(CC) $(LDFLAGS) .test.o -o .test $(LIBS) >/dev/null 2>&1 && \ echo "yes." || ( echo "no."; \ - printf "Checking if libz is present and supplies all needed symbols..."; \ - $(CC) $(LDFLAGS) .test.o -o .test -lpci -lz $(LIBS) >/dev/null 2>&1 && \ + printf "Checking if libz+libpci are present and sufficient..."; \ + $(CC) $(LDFLAGS) .test.o -o .test $(LIBS) -lz >/dev/null 2>&1 && \ ( echo "yes."; echo "NEEDLIBZ := yes" > .libdeps ) || ( echo "no."; echo; \ - echo "Please install libz."; \ + echo "Please install libpci (package pciutils) and/or libz."; \ echo "See README for more information."; echo; \ rm -f .test.c .test.o .test; exit 1) ) - @rm -f .test.c .test.o .test .test1.c .test1 + @rm -f .test.c .test.o .test else pciutils: compiler @printf "" > .libdeps

1 0

[commit] r967 - trunk
by repository service 22 Mar '10

22 Mar '10

Author: snelson Date: Mon Mar 22 08:03:26 2010 New Revision: 967 URL: http://flashrom.org/trac/coreboot/changeset/967 Log: in unlock_28f004s5, variable 'i' needs to be int... Signed-off-by: Sean Nelson <audiohacked(a)gmail.com> Acked-by: Sean Nelson <audiohacked(a)gmail.com> Modified: trunk/82802ab.c Modified: trunk/82802ab.c ============================================================================== --- trunk/82802ab.c Mon Mar 22 07:57:02 2010 (r966) +++ trunk/82802ab.c Mon Mar 22 08:03:26 2010 (r967) @@ -209,7 +209,8 @@ int unlock_28f004s5(struct flashchip *flash) { chipaddr bios = flash->virtual_memory; - uint8_t mcfg, bcfg, need_unlock = 0, can_unlock = 0, i; + uint8_t mcfg, bcfg, need_unlock = 0, can_unlock = 0; + int i; /* Clear status register */ chip_writeb(0x50, bios);

1 0

[PATCH] Intel 28F001BX fix
by Sean Nelson 22 Mar '10

22 Mar '10

see patch:

2 10

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom